Skip to content

fix(navigator): ignore zero-initialized takeoff coordinates - #28792

Open
onelittlechildawa wants to merge 1 commit into
PX4:mainfrom
onelittlechildawa:onelittlechildawa/fix-takeoff-zero-coordinates
Open

onelittlechildawa wants to merge 1 commit into
PX4:mainfrom
onelittlechildawa:onelittlechildawa/fix-takeoff-zero-coordinates

Conversation

@onelittlechildawa

Copy link
Copy Markdown
Contributor

Summary

Use the current position when a standalone takeoff command leaves both coordinates at zero.

Problem

The rotary-wing takeoff path accepts (0, 0) as an explicit horizontal target.

Solution

Apply the existing current-position fallback to a zero-initialized coordinate pair.

Signed-off-by: onelittlechildawa <onelittlechild@outlook.com>
Assisted-by: Codex
Copilot AI balanced review requested due to automatic review settings September 22, 2026 07:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added kind:bug Something is broken or behaving incorrectly. scope:navigation Missions, RTL, geofence, takeoff, landing, or navigator behavior. labels Sep 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 32 byte (0 %)]
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +32  +0.0%     +32    .text
    +0.7%     +32  +0.7%     +32    Navigator::run()
  +0.0%     +55  [ = ]       0    .debug_abbrev
  -0.0%      -2  [ = ]       0    .debug_info
  -0.0%      -5  [ = ]       0    .debug_line
  -0.3%     -32  [ = ]       0    [Unmapped]
  +0.0%     +48  +0.0%     +32    TOTAL

px4_fmu-v6x [Total VM Diff: 32 byte (0 %)]
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +32  +0.0%     +32    .text
    +0.7%     +32  +0.7%     +32    Navigator::run()
  +0.0%     +55  [ = ]       0    .debug_abbrev
  -0.0%      -2  [ = ]       0    .debug_info
  -0.0%      -5  [ = ]       0    .debug_line
  -0.5%     -32  [ = ]       0    [Unmapped]
  +0.0%     +48  +0.0%     +32    TOTAL

Updated: 2026-09-22T07:32:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug Something is broken or behaving incorrectly. scope:navigation Missions, RTL, geofence, takeoff, landing, or navigator behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants