fix(tap_esc): correct CRC verification debug output - #28790
Open
onelittlechildawa wants to merge 1 commit into
Open
onelittlechildawa wants to merge 1 commit into
onelittlechildawa wants to merge 1 commit into
Conversation
Read debug fields from the same CRC feedback layout used for validation to avoid logging CRC data as the command. Signed-off-by: onelittlechildawa <onelittlechild@outlook.com> Assisted-by: Codex
github-actions
Bot
added
the
kind:bug
github-actions
Bot
added
scope:drivers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep CRC verification diagnostics consistent with the response being checked.
Problem
The bad-command log reads the ordinary feedback layout, so it prints CRC data instead of the command being checked.
Solution
Read the debug-log fields from the CRC feedback packet.