Skip to content

NMS-19223: add node message to ResponseTimeResource messages#8186

Merged
christianpape merged 2 commits intoOpenNMS:foundation-2025from
dschlenk:feature/add-node-to-response-time-resources
Apr 9, 2026
Merged

NMS-19223: add node message to ResponseTimeResource messages#8186
christianpape merged 2 commits intoOpenNMS:foundation-2025from
dschlenk:feature/add-node-to-response-time-resources

Conversation

@dschlenk
Copy link
Copy Markdown
Contributor

@dschlenk dschlenk commented Dec 9, 2025

All Contributors

Contribution Checklist

  • Please make an issue in the OpenNMS issue tracker if there isn't one already.
    Once there is an issue, please:
    1. update the title of this PR to be in the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the Jira link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
    4. once you've created this PR, please link to it in a comment in the Jira issue
      Don't worry if this sounds like a lot, we can help you get things set up properly.
  • If this code is likely to affect the UI, did you name your branch with -smoke in it to trigger smoke tests?
  • If this is a new or updated feature, is there documentation for the new behavior?
  • If this is new code, are there unit and/or integration tests?
  • If this PR targets a foundation-* branch, does it try to avoid changing files in $OPENNMS_HOME/etc/?

What's Next?

A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.

If you need help making additions or changes to the documentation related to your changes, please let us know.

In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.

Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

Copy link
Copy Markdown
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. @dschlenk.

Please resolve the conflict, then this is good to go.

Do you want this in any of the foundation branches instead of develop ?

@christianpape christianpape changed the base branch from develop to foundation-2025 April 8, 2026 13:39
dschlenk added 2 commits April 8, 2026 15:55
Signed-off-by: David Schlenk <dschlenk@onec1.com>
Signed-off-by: David Schlenk <dschlenk@onec1.com>
@christianpape christianpape force-pushed the feature/add-node-to-response-time-resources branch from 13307ba to f395499 Compare April 8, 2026 13:55
@christianpape christianpape requested a review from cgorantla April 9, 2026 05:36
@christianpape
Copy link
Copy Markdown
Contributor

I rebased the branch and resolved the conflict.

See CircleCI:

Copy link
Copy Markdown
Contributor

@cgorantla cgorantla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christianpape christianpape merged commit 7329a9b into OpenNMS:foundation-2025 Apr 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants