NMS-19395: Added metricFilter to kafka-producer#8409
Open
christianpape wants to merge 2 commits intofoundation-2025from
Open
NMS-19395: Added metricFilter to kafka-producer#8409christianpape wants to merge 2 commits intofoundation-2025from
christianpape wants to merge 2 commits intofoundation-2025from
Conversation
Contributor
christianpape
commented
Apr 1, 2026
christianpape
commented
- JIRA: https://opennms.atlassian.net/browse/NMS-19395
christianpape
force-pushed
the
jira/NMS-19395
branch
from
601c142 to
cf074ac
Compare
christianpape
force-pushed
the
jira/NMS-19395
branch
from
cf074ac to
ba7cc8e
Compare
cgorantla
reviewed
Apr 7, 2026
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Good work. I have few comments to take care.
...ka/producer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersister.java
Show resolved
Hide resolved
...ka/producer/src/main/java/org/opennms/features/kafka/producer/collection/KafkaPersister.java
Outdated
Show resolved
Hide resolved
| } else if (resource.hasGeneric() && !resource.getGeneric().getNode().getNodeLabel().isEmpty()) { | ||
| nodeLabel = resource.getGeneric().getNode().getNodeLabel(); | ||
| } | ||
| return nodeLabel; |
Contributor
There was a problem hiding this comment.
So what happens when CollectionSetResource has response time resources and we filter by nodeLabel ~= "Cisco". I think this might create different results as we are missing node in response time resources.
We might want to take #8186 for taking care of this.
Contributor
Author
There was a problem hiding this comment.
Should I take care of #8186 and merge this PR first?
christianpape
force-pushed
the
jira/NMS-19395
branch
from
fb10199 to
ca633e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.