-
Notifications
You must be signed in to change notification settings - Fork 31
Add meno axiom to energy transformation and subclasses #2053 #2120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 67fb421.
|
TODOS from the oeo-dev meeting in oldenburg (27.19.25), these axioms should be adapted from EquivalentClass to Subclass:
|
|
Did we already decide on whether to keep the OEO |
|
This PR should wait for #2136 to be merged and then add an update on propulsion. |
Not finally... |
|
This PR is waiting for a review for quite some time. Tomorrow is the release and I really would like to include it. |
b-gehrke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks 👍
Summary of the discussion
We decided to not use
has energy participantand subclasses anymore, see #2053. Also we integrated from MENOenergy transformationandenergy transferto replace OEOs own concepts.Type of change (CHANGELOG.md)
Update
energy transformation (OEO): added the simplified meno axiom from Makehas energy participantobsolete #2053 as subclassOf and removehas energy participantaxiomshas energy participantaxioms:combined heat and power generation processcombined cycle electricity generation processelectricity generation/gain processfuel-powered electricity generation processcombustion thermal energy trafogas turbine processheat generation/gain processhydro energy trafohydroelectric energy trafo and subclassesnuclear energy trafopower-to-fuelpower-to-gaspower-to-liquidpower-to-ammoniapower-to-methanesolar energy transformationand subclassessolar steam electric processwater electrolysis processwind energy trafosteam reformingoeo:energy transferpropulsionWorkflow checklist
Automation
Closes #2053
PR-Assignee
term tracker annotationReviewer