Skip to content

Conversation

@stap-m
Copy link
Contributor

@stap-m stap-m commented Sep 25, 2025

Summary of the discussion

We decided to not use has energy participant and subclasses anymore, see #2053. Also we integrated from MENO energy transformation and energy transfer to replace OEOs own concepts.

Type of change (CHANGELOG.md)

Update

  • energy transformation (OEO): added the simplified meno axiom from Make has energy participant obsolete #2053 as subclassOf and remove has energy participant axioms
  • added specified axioms to these subprocesses and remove has energy participant axioms:
    • combined heat and power generation process
    • combined cycle electricity generation process
    • electricity generation/gain process
    • fuel-powered electricity generation process
    • combustion thermal energy trafo
    • gas turbine process
    • heat generation/gain process
    • hydro energy trafo
    • hydroelectric energy trafo and subclasses
    • nuclear energy trafo
    • power-to-fuel
    • power-to-gas
    • power-to-liquid
    • power-to-ammonia
    • power-to-methane
    • solar energy transformation and subclasses
    • solar steam electric process
    • water electrolysis process
    • wind energy trafo
    • steam reforming
    • oeo:energy transfer
    • propulsion

Workflow checklist

Automation

Closes #2053

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-physical changes the oeo-physical module oeo.omn changes the oeo.omn -module labels Sep 25, 2025
@stap-m stap-m added this to Issues Sep 25, 2025
@github-project-automation github-project-automation bot moved this to Review in progress in Issues Sep 25, 2025
@stap-m stap-m requested a review from areleu October 1, 2025 08:10
@stap-m stap-m mentioned this pull request Oct 8, 2025
5 tasks
@stap-m stap-m requested a review from b-gehrke October 8, 2025 07:40
@stap-m stap-m self-assigned this Oct 8, 2025
@enioarz
Copy link

enioarz commented Oct 27, 2025

TODOS from the oeo-dev meeting in oldenburg (27.19.25), these axioms should be adapted from EquivalentClass to Subclass:

  • electricity generation process:
    • rename to "electricity gain process"
    • alternative label: electricity generation process
    • add comment on why electricity transfer is inferred (matter of perspective)
    • keep equivalence axiom
  • same approach for heat generation process
  • solar energy transformation

@b-gehrke
Copy link
Contributor

Did we already decide on whether to keep the OEO energy transfer and energy transformation (sub)classes or to replace them entirely? At the moment, both, MENO and OEO classes with the same label, exist.

@stap-m
Copy link
Contributor Author

stap-m commented Nov 21, 2025

This PR should wait for #2136 to be merged and then add an update on propulsion.

@stap-m stap-m marked this pull request as ready for review November 24, 2025 11:50
@stap-m stap-m requested a review from amanda-wein November 24, 2025 12:34
@stap-m
Copy link
Contributor Author

stap-m commented Nov 24, 2025

Did we already decide on whether to keep the OEO energy transfer and energy transformation (sub)classes or to replace them entirely? At the moment, both, MENO and OEO classes with the same label, exist.

Not finally...

@Ludee Ludee changed the title add meno axiom to energy transformation and subclasses #2053 Add meno axiom to energy transformation and subclasses #2053 Dec 5, 2025
@Ludee Ludee self-requested a review December 5, 2025 09:15
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Changed axioms per ontology

Note: Changes in term tracker annotations are not displayed

oeo-physical.omn: 134 changes

Ontology comparison

Left

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/oeo-physical/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo-physical.omn
  • Loaded from: file:/__w/ontology/ontology/./dev/src/ontology/edits/oeo-physical.omn

Right

  • Ontology IRI: https://openenergyplatform.org/ontology/oeo/oeo-physical/
  • Version IRI: https://openenergyplatform.org/ontology/oeo/dev/oeo-physical.omn
  • Loaded from: file:/__w/ontology/ontology/src/ontology/edits/oeo-physical.omn

Ontology imports

Ontology annotations

ambient thermal energy transfer https://openenergyplatform.org/ontology/oeo/OEO_00140106

Added

charging https://openenergyplatform.org/ontology/oeo/OEO_00320064

Removed

Added

chemical energy transfer https://openenergyplatform.org/ontology/oeo/OEO_00320037

Removed

Added

combined cycle electricity generation process https://openenergyplatform.org/ontology/oeo/OEO_00310025

Removed

Added

combined heat and power generation process https://openenergyplatform.org/ontology/oeo/OEO_00240009

Removed

Added

combustion thermal energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00010249

Removed

Added

electrical energy transfer https://openenergyplatform.org/ontology/oeo/OEO_00320036

Removed

Added

electricity generation process https://openenergyplatform.org/ontology/oeo/OEO_00240014

Removed

Added

energy decrease https://raw.githubusercontent.com/stap-m/midlevel-energy-ontology/main/ontology/src/midlevel-energy.owl/MENO_01013

Added

energy increase https://raw.githubusercontent.com/stap-m/midlevel-energy-ontology/main/ontology/src/midlevel-energy.owl/MENO_01014

Added

energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00020003

Removed

Added

fuel-powered electricity generation process https://openenergyplatform.org/ontology/oeo/OEO_00050001

Removed

Added

gas turbine process https://openenergyplatform.org/ontology/oeo/OEO_00310027

Removed

Added

geothermal heat transfer https://openenergyplatform.org/ontology/oeo/OEO_00020059

Removed

Added

has occurrent part http://purl.obolibrary.org/obo/BFO_0000117

Added

heat generation process https://openenergyplatform.org/ontology/oeo/OEO_00010248

Removed

Added

heat transfer https://openenergyplatform.org/ontology/oeo/OEO_00140101

Removed

Added

hydro energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00110004

Removed

Added

hydroelectric energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00110005

Removed

Added

marine current energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00010098

Removed

Added

marine thermal energy transfer https://openenergyplatform.org/ontology/oeo/OEO_00010096

Added

marine tidal energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00010099

Removed

Added

marine wave energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00010103

Removed

Added

negatively regulates characteristic http://purl.obolibrary.org/obo/RO_0019002

Added

nuclear energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00020054

Removed

Added

photovoltaic energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00020048

Removed

Added

positively regulates characteristic http://purl.obolibrary.org/obo/RO_0019001

Added

power-to-ammonia process https://openenergyplatform.org/ontology/oeo/OEO_00010222

Removed

Added

power-to-fuel process https://openenergyplatform.org/ontology/oeo/OEO_00330007

Removed

Added

power-to-gas process https://openenergyplatform.org/ontology/oeo/OEO_00010216

Removed

Added

power-to-liquid process https://openenergyplatform.org/ontology/oeo/OEO_00330008

Removed

Added

power-to-methane process https://openenergyplatform.org/ontology/oeo/OEO_00010217

Removed

Added

propulsion https://openenergyplatform.org/ontology/oeo/OEO_00020251

Removed

Added

radiation https://openenergyplatform.org/ontology/oeo/OEO_00020037

Added

solar chemical energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00010081

Removed

Added

solar energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00020046

Removed

Added

solar thermal energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00020047

Removed

Added

solar-steam-electric process https://openenergyplatform.org/ontology/oeo/OEO_00010080

Removed

Added

steam reforming https://openenergyplatform.org/ontology/oeo/OEO_00010267

Removed

Added

water electrolysis process https://openenergyplatform.org/ontology/oeo/OEO_00010219

Removed

Added

wind energy transformation https://openenergyplatform.org/ontology/oeo/OEO_00020043

Removed

Added

@stap-m
Copy link
Contributor Author

stap-m commented Dec 9, 2025

This PR is waiting for a review for quite some time. Tomorrow is the release and I really would like to include it.
The fist commits were reviewed and agreed upon in a meeting on oct 28 with @b-gehrke @amanda-wein @areleu and me. But the newer commits have not yet received a review. 🙏

Copy link
Contributor

@b-gehrke b-gehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Issues Dec 9, 2025
@stap-m stap-m merged commit 72ee9c9 into dev Dec 10, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Issues Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oeo.omn changes the oeo.omn -module oeo-physical changes the oeo-physical module

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make has energy participant obsolete

4 participants