Skip to content

Conversation

@stap-m
Copy link
Contributor

@stap-m stap-m commented Nov 11, 2025

Summary of the discussion

Based on #2136.
The gas turbine process is inferred as propulsion. Therefore, we add two new entities: motion and translational energy.
Like this, propulsion can refer to translational energy instead of kinetic energy (parent) and the inference is correct.

The update of propulsion should be done in #2120 !!

Type of change (CHANGELOG.md)

Add

  • motion
  • translational energy

Workflow checklist

Automation

Closes #2136

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m added this to Issues Nov 11, 2025
@stap-m stap-m self-assigned this Nov 11, 2025
@github-project-automation github-project-automation bot moved this to Review in progress in Issues Nov 11, 2025
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Nov 11, 2025
@stap-m stap-m marked this pull request as ready for review November 11, 2025 08:41
@stap-m
Copy link
Contributor Author

stap-m commented Nov 11, 2025

Please check the text of the definition proposal.

Copy link
Contributor

@amanda-wein amanda-wein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for the definition of motion: "Motion is an energy transformation where some kind of energy is transformed into kinetic energy, and the bearer of the kinetic energy changes its position or location."

Copy link
Contributor

@amanda-wein amanda-wein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, thanks!

@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Issues Nov 21, 2025
@stap-m stap-m merged commit b71dc14 into dev Nov 21, 2025
3 checks passed
@stap-m stap-m deleted the feature-2136-motion branch November 21, 2025 10:02
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Issues Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oeo-physical changes the oeo-physical module

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

add motion and update propulsion

3 participants