feat(i18n): add 42 translation keys for TraderConfigModal#1374
Merged
tinkle-community merged 1 commit intoNoFxAiOS:devfrom Feb 9, 2026
Merged
feat(i18n): add 42 translation keys for TraderConfigModal#1374tinkle-community merged 1 commit intoNoFxAiOS:devfrom
tinkle-community merged 1 commit intoNoFxAiOS:devfrom
Conversation
- Add new translation keys for all hardcoded Chinese strings
- Replace hardcoded UI text with t('key', language) calls
- Support both English and Chinese languages
Modified files:
- web/src/i18n/translations.ts: +88 lines (42 new keys)
- web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings
|
|
Contributor
Author
|
Status Update for Maintainers: This PR #1374 adds zh (Chinese) language translations for TraderConfigModal.tsx. Note: There is also PR #1343 by @maker95 which is working on i18n improvements with es (Spanish) language. Both PRs modify the same files:
We use Options to resolve:
Let us know which approach you prefer, and we're happy to help coordinate! 🙏 |
xsa-dev
added a commit
to xsa-dev/nofx
that referenced
this pull request
Feb 8, 2026
- 275+ translation keys from 8 strategy components - 3 languages: English, Chinese, Spanish - Ready for integration into translations.ts - Pre-aggregated exports for zhStrategy, enStrategy, esStrategy Related to PR NoFxAiOS#1343 (maker95) and NoFxAiOS#1374 (xsa-dev)
xsa-dev
added a commit
to xsa-dev/nofx
that referenced
this pull request
Feb 8, 2026
- Consolidate 275+ translation keys into strategy-translations.ts
- Migrate 8 strategy components to use centralized i18n pattern
- Components: CoinSourceEditor, GridRiskPanel, RiskControlEditor,
GridConfigEditor, PromptSectionsEditor, IndicatorEditor,
PublishSettingsEditor, ChartTabs
- Add Spanish (es) translations for all strategy components
- Remove inline { zh, en } translation objects from components
- Use standard t(key, language) pattern throughout
Related: NoFxAiOS#1343 (maker95 - es language), NoFxAiOS#1374 (xsa-dev - zh TraderConfigModal)
Co-authored-by: xsa-dev <xsa-dev@users.noreply.github.com>
tinkle-community
pushed a commit
that referenced
this pull request
Feb 9, 2026
…#1375) * feat(i18n): add 42 translation keys for TraderConfigModal - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings * feat(i18n): add consolidated translation keys (en + zh + es) - 275+ translation keys from 8 strategy components - 3 languages: English, Chinese, Spanish - Ready for integration into translations.ts - Pre-aggregated exports for zhStrategy, enStrategy, esStrategy Related to PR #1343 (maker95) and #1374 (xsa-dev)
Hansen1018
pushed a commit
to Hansen1018/nofx
that referenced
this pull request
Feb 9, 2026
) - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings
gqzydh
pushed a commit
to gqzydh/nofx
that referenced
this pull request
Feb 13, 2026
) - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings
Hansen1018
added a commit
to Hansen1018/nofx
that referenced
this pull request
Feb 26, 2026
) - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings
Hansen1018
pushed a commit
to Hansen1018/nofx
that referenced
this pull request
Mar 11, 2026
…NoFxAiOS#1375) * feat(i18n): add 42 translation keys for TraderConfigModal - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings * feat(i18n): add consolidated translation keys (en + zh + es) - 275+ translation keys from 8 strategy components - 3 languages: English, Chinese, Spanish - Ready for integration into translations.ts - Pre-aggregated exports for zhStrategy, enStrategy, esStrategy Related to PR NoFxAiOS#1343 (maker95) and NoFxAiOS#1374 (xsa-dev)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix hardcoded Chinese strings in TraderConfigModal component that were displayed even when English language was selected.
Changes
web/src/i18n/translations.tst('key', language)calls inweb/src/components/TraderConfigModal.tsxKey Translations Added
Testing
English text now displays correctly when English is selected in language settings.