Open
Conversation
…tegy studio - Hyperliquid Focused - Enhanced RiskControlEditor to support trailing stop configuration with various parameters including activation percentage, trail distance, and check interval. - Updated StrategyStudioPage to normalize trailing stop settings when fetching strategies. - Introduced display logic for trailing stop status in TraderDashboardPage. - Added TrailingStatus and TrailingStopConfig types to manage trailing stop configurations. - Implemented tests for trailing stop configuration defaults and unmarshalling behavior. - Created HyperliquidPriceStream for managing websocket subscriptions for price updates. Important Notes: This feature replaces the Drawdown Monitor for a more sophisticated and controllable trailing stop feature that can be configured in the Strategy Editor (risk controls). For now, the performant WebSocket prices monitor for trailing-enabled positions is only implemented in the Hyperliquid exchange, followup commits will integrate websocket position status monitor to more exchanges so this feature enables sub-second position monitoring for the trailing stop to react quickly while other exchanges still rely on REST API so a > 1 second Check Interval is advisable to avoid flooding the REST API of the other exchanges that are not WebSocket enabled yet. For the exchanges that are not Hyperliquid, a Check Interval of 5000 ms ( 5 seconds) should work just fine if you expect like 4-5 positions open at the same time, for less positions you may try to lower the check interval for better reactiveness. Ensure to check logs to confirm expected behavior.
Author
|
Fix some UI copy in English language and adds Spanish language support. This pr is focused on improved internationalization consistency and Spanish language addition. |
Contributor
|
Hi @maker95! Just wanted to let you know there's another PR #1374 that's also working on i18n but for zh (Chinese) language. Our PR #1374 adds 42 translation keys for zh language in TraderConfigModal.tsx using Since both PRs modify the same files (translations.ts and TraderConfigModal.tsx), it would be great to coordinate to avoid conflicts. Would you like us to rebase our changes onto your branch using your Happy to help merge our efforts! 🙏 |
xsa-dev
added a commit
to xsa-dev/nofx
that referenced
this pull request
Feb 8, 2026
- 275+ translation keys from 8 strategy components - 3 languages: English, Chinese, Spanish - Ready for integration into translations.ts - Pre-aggregated exports for zhStrategy, enStrategy, esStrategy Related to PR NoFxAiOS#1343 (maker95) and NoFxAiOS#1374 (xsa-dev)
xsa-dev
added a commit
to xsa-dev/nofx
that referenced
this pull request
Feb 8, 2026
- Consolidate 275+ translation keys into strategy-translations.ts
- Migrate 8 strategy components to use centralized i18n pattern
- Components: CoinSourceEditor, GridRiskPanel, RiskControlEditor,
GridConfigEditor, PromptSectionsEditor, IndicatorEditor,
PublishSettingsEditor, ChartTabs
- Add Spanish (es) translations for all strategy components
- Remove inline { zh, en } translation objects from components
- Use standard t(key, language) pattern throughout
Related: NoFxAiOS#1343 (maker95 - es language), NoFxAiOS#1374 (xsa-dev - zh TraderConfigModal)
Co-authored-by: xsa-dev <xsa-dev@users.noreply.github.com>
tinkle-community
pushed a commit
that referenced
this pull request
Feb 9, 2026
…#1375) * feat(i18n): add 42 translation keys for TraderConfigModal - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings * feat(i18n): add consolidated translation keys (en + zh + es) - 275+ translation keys from 8 strategy components - 3 languages: English, Chinese, Spanish - Ready for integration into translations.ts - Pre-aggregated exports for zhStrategy, enStrategy, esStrategy Related to PR #1343 (maker95) and #1374 (xsa-dev)
Hansen1018
pushed a commit
to Hansen1018/nofx
that referenced
this pull request
Mar 11, 2026
…NoFxAiOS#1375) * feat(i18n): add 42 translation keys for TraderConfigModal - Add new translation keys for all hardcoded Chinese strings - Replace hardcoded UI text with t('key', language) calls - Support both English and Chinese languages Modified files: - web/src/i18n/translations.ts: +88 lines (42 new keys) - web/src/components/TraderConfigModal.tsx: replaced 48 hardcoded strings * feat(i18n): add consolidated translation keys (en + zh + es) - 275+ translation keys from 8 strategy components - 3 languages: English, Chinese, Spanish - Ready for integration into translations.ts - Pre-aggregated exports for zhStrategy, enStrategy, esStrategy Related to PR NoFxAiOS#1343 (maker95) and NoFxAiOS#1374 (xsa-dev)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📝 Description
🎯 Type of Change
🔗 Related Issues
📋 Changes Made
🧪 Testing
✅ Checklist
Code Quality
Documentation
Git
devbranch📚 Additional Notes
By submitting this PR, I confirm:
🌟 Thank you for your contribution!