Skip to content

cue: run tests correctly #431906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

cue: run tests correctly #431906

wants to merge 2 commits into from

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Aug 8, 2025 •
edited
Loading

  • cue.passthru: ensure all attrs use final overriden package
  • cue: add tests.cue-validation to tests

See #430141 and #431813 for context.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@eclairevoyant eclairevoyant mentioned this pull request Aug 8, 2025
Merged
@eclairevoyant

This comment was marked as resolved.

Sign in to view
@eclairevoyant eclairevoyant mentioned this pull request Aug 8, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 8, 2025
@eclairevoyant eclairevoyant marked this pull request as draft August 8, 2025 02:09
@eclairevoyant eclairevoyant marked this pull request as ready for review August 8, 2025 02:23
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 8, 2025
@eclairevoyant

This comment was marked as outdated.

Sign in to view
@eclairevoyant
Copy link
Contributor Author

@Aleksanaa @aaronjheng would you be willing to review this change as well? This should ensure we don't accidentally cause build issues for users wrt bootspec/cue.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 5, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5873

@eclairevoyant eclairevoyant deleted the cue-valid branch September 29, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aaronjheng aaronjheng aaronjheng approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eclairevoyant @nixos-discourse @aaronjheng