cue.validator: fix deprecated --strict flag #431813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --strict flag was deprecated in CUE 0.14.0 and causes NixOS builds to fail with: '--strict is deprecated; use "jsonschema+strict:" as shown in "cue help filetypes"' Since strict validation is now the default behavior in CUE, we can safely remove this flag without changing functionality.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
This was referenced Aug 8, 2025
eclairevoyant
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Thank you for fixing this! I've created #431906 to prevent similar issues from making it to nixos-unstable in the future.
nixpkgs-ci
bot
added
the
12.approvals: 1
|
@aaronjheng for review (not sure why CI didn't ping here) |
aaronjheng
approved these changes
Aug 13, 2025
nixpkgs-ci
bot
added
12.approvals: 2
|
Is something blocking this? |
|
yes, it's pending a committer noticing and clicking the merge button |
aviallon
approved these changes
Sep 4, 2025
nixpkgs-ci
bot
added
12.approvals: 3+
|
@ElvishJerricco do you or another committer have a chance to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --strict flag was deprecated in CUE 0.14.0 and causes NixOS builds to fail with: '--strict is deprecated; use "jsonschema+strict:" as shown in "cue help filetypes"'
Since strict validation is now the default behavior in CUE, we can safely remove this flag without changing functionality.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.