-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix: black screen when using routeType with navigateTo in Skyline mode #18883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Everestbs
wants to merge
2
commits into
NervJS:main
Choose a base branch
from
Everestbs:fix/skyline-navigateto-black-screen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail路径中reject可能不会执行;complete的处理方式与success/fail不一致两个问题:
fail回调抛出异常(第 48 行),reject(err)将不会执行,导致 Promise 永远处于 pending 状态。complete直接透传给 wx(第 51 行),而success和fail则被包装过。如果将来需要在complete中添加逻辑(或保证与 resolve/reject 的执行顺序一致),当前写法不便扩展。建议统一包装所有回调,并对
fail分支做防护处理:🛠️ 建议修改
return new Promise((resolve, reject) => { const { success, fail, complete, ...restOptions } = options wx.navigateTo({ ...restOptions, success: (res) => { success?.(res) + complete?.(res) resolve(res) }, fail: (err) => { - fail?.(err) - reject(err) + try { + fail?.(err) + } catch (e) { + // ignore + } + complete?.(err) + reject(err) }, - complete }) })🤖 Prompt for AI Agents