fix: black screen when using routeType with navigateTo in Skyline mode#18883
Open
Everestbs wants to merge 2 commits intoNervJS:mainfrom
Open
fix: black screen when using routeType with navigateTo in Skyline mode#18883Everestbs wants to merge 2 commits intoNervJS:mainfrom
Everestbs wants to merge 2 commits intoNervJS:mainfrom
Conversation
Walkthrough在 WeChat 小程序平台的 API 初始化中，保存原始 Changes
Sequence Diagram(s)sequenceDiagram
participant App as "调用方 (App)"
participant Taro as "taro.navigateTo (包装)"
participant WX as "wx.navigateTo (原生)"
App->>Taro: navigateTo({ url, routeType })
alt routeType 存在 且 renderer === 'skyline'
Taro->>WX: wx.navigateTo({ url, routeType }, callbacks)
WX-->>Taro: success / fail / complete
Taro-->>App: Promise resolve / reject
else
Taro->>Taro: originalNavigateTo.call(taro, options)
Taro-->>App: 原始返回值/行为
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/taro-platform-weapp/src/apis.ts`:
- Around line 39-53: 当前 wx.navigateTo 包装没有保护用户回调：调用 success/fail
前直接执行用户回调可能会抛出，导致 resolve/reject 不被调用，且 complete 未被统一包装。修改 wx.navigateTo
包装逻辑（在包裹的函数中操作 options 的 success/fail/complete）将 success/fail/complete
三个回调都用内部封装替换；在 success 回调中用 try/catch/ finally 或先行 resolve 再调用用户
success（或将用户回调包在 try/catch 并在 finally 中 resolve），在 fail 回调中保证不论用户 fail 回调是否抛出都执行
reject（即在 try { userFail?.(err) } catch{} finally { reject(err) }），并把 complete
也替换为内部函数（在 resolve/reject 后统一调用用户 complete 并用 try/catch 包裹），并在代码中定位到 options,
wx.navigateTo, success, fail, complete 以应用这些改动。
Comment on lines
+39
to
+53
| return new Promise((resolve, reject) => { | ||
| const { success, fail, complete, ...restOptions } = options | ||
| wx.navigateTo({ | ||
| ...restOptions, | ||
| success: (res) => { | ||
| success?.(res) | ||
| resolve(res) | ||
| }, | ||
| fail: (err) => { | ||
| fail?.(err) | ||
| reject(err) | ||
| }, | ||
| complete | ||
| }) | ||
| }) |
There was a problem hiding this comment.
fail 路径中 reject 可能不会执行；complete 的处理方式与 success/fail 不一致
两个问题：
- 如果用户提供的
fail回调抛出异常（第 48 行），reject(err)将不会执行，导致 Promise 永远处于 pending 状态。 complete直接透传给 wx（第 51 行），而success和fail则被包装过。如果将来需要在complete中添加逻辑（或保证与 resolve/reject 的执行顺序一致），当前写法不便扩展。
建议统一包装所有回调，并对 fail 分支做防护处理：
🛠️ 建议修改
return new Promise((resolve, reject) => {
const { success, fail, complete, ...restOptions } = options
wx.navigateTo({
...restOptions,
success: (res) => {
success?.(res)
+ complete?.(res)
resolve(res)
},
fail: (err) => {
- fail?.(err)
- reject(err)
+ try {
+ fail?.(err)
+ } catch (e) {
+ // ignore
+ }
+ complete?.(err)
+ reject(err)
},
- complete
})
})🤖 Prompt for AI Agents
In `@packages/taro-platform-weapp/src/apis.ts` around lines 39 - 53, 当前
wx.navigateTo 包装没有保护用户回调：调用 success/fail 前直接执行用户回调可能会抛出，导致 resolve/reject 不被调用，且
complete 未被统一包装。修改 wx.navigateTo 包装逻辑（在包裹的函数中操作 options 的
success/fail/complete）将 success/fail/complete 三个回调都用内部封装替换；在 success 回调中用
try/catch/ finally 或先行 resolve 再调用用户 success（或将用户回调包在 try/catch 并在 finally 中
resolve），在 fail 回调中保证不论用户 fail 回调是否抛出都执行 reject（即在 try { userFail?.(err) }
catch{} finally { reject(err) }），并把 complete 也替换为内部函数（在 resolve/reject 后统一调用用户
complete 并用 try/catch 包裹），并在代码中定位到 options, wx.navigateTo, success, fail,
complete 以应用这些改动。
Author
|
Hi @Single-Dancer 您好！ |
Single-Dancer
approved these changes
Feb 26, 2026
This was referenced Feb 28, 2026
Author
|
Hi @Single-Dancer 您好！ |
Single-Dancer
force-pushed
the
fix/skyline-navigateto-black-screen
branch
from
b0cc5b5 to
0191020
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/taro-platform-weapp/src/apis.ts (1)
48-60:⚠️ Potential issue | 🟠 Major回调异常会打断 Promise settle，仍可能出现 pending
在 Line 49/50/59，
success/complete的异常未被完整隔离；若用户回调抛错，resolve/reject可能不执行，调用方会卡住。建议统一做“安全回调 + 保证 settle”。建议修改
if (renderer === 'skyline') { return new Promise((resolve, reject) => { const { success, fail, complete, ...restOptions } = options + const safeCall = (cb, arg) => { + try { + cb?.(arg) + } catch (e) { + // ignore user callback errors to avoid breaking promise settlement + } + } wx.navigateTo({ ...restOptions, success: (res) => { - success?.(res) - complete?.(res) + safeCall(success, res) + safeCall(complete, res) resolve(res) }, fail: (err) => { - try { - fail?.(err) - } catch (e) { - // ignore - } - complete?.(err) + safeCall(fail, err) + safeCall(complete, err) reject(err) } }) }) }Based on learnings: 在 Taro 的 getRectSizeSync 函数中，如果找不到指定的节点，函数会一直处于 pending 状态而不是抛出错误，需要避免无限等待。
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/taro-platform-weapp/src/apis.ts` around lines 48 - 60, The Promise can remain pending if user-provided callbacks (success/complete/fail) throw; to fix, ensure resolve/reject always run regardless of callback errors by invoking resolve(res)/reject(err) before calling user callbacks or by wrapping user calls in try/catch (safeInvoke) and then settling the Promise; update the handlers in apis.ts for the success, fail and complete paths (the success: (res) => { ... }, fail: (err) => { ... } blocks) to guarantee resolve(res)/reject(err) is executed even if success/fail/complete throw, and optionally extract a small helper (e.g., safeInvoke(callback, arg)) to centralize the try/catch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@packages/taro-platform-weapp/src/apis.ts`:
- Around line 48-60: The Promise can remain pending if user-provided callbacks
(success/complete/fail) throw; to fix, ensure resolve/reject always run
regardless of callback errors by invoking resolve(res)/reject(err) before
calling user callbacks or by wrapping user calls in try/catch (safeInvoke) and
then settling the Promise; update the handlers in apis.ts for the success, fail
and complete paths (the success: (res) => { ... }, fail: (err) => { ... }
blocks) to guarantee resolve(res)/reject(err) is executed even if
success/fail/complete throw, and optionally extract a small helper (e.g.,
safeInvoke(callback, arg)) to centralize the try/catch.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b472a016-b077-4462-a29d-b57be515e4f3
📒 Files selected for processing (1)
packages/taro-platform-weapp/src/apis.ts
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么？ (简要描述所做更改)
修复 Skyline 渲染模式下使用
navigateTo配置routeType参数导致页面黑屏的问题。在 Skyline 模式下，当调用
Taro.navigateTo({ url, routeType: 'wx://upwards' })时，Taro 运行时会尝试在 JavaScript 层应用动画样式，但 Skyline 的节点存在于原生渲染层，导致[ui] applyAnimatedStyle can not find corresponding nodes错误，页面黑屏崩溃。本次修复通过检测 Skyline 模式并直接调用微信原生
wx.navigateToAPI，绕过 Taro 运行时的动画处理层，彻底解决该问题。这个 PR 是什么类型？ (至少选择一个)
这个 PR 涉及以下平台：
问题描述
Closes #18879
现象：在微信小程序 Skyline 渲染模式下，使用
navigateTo配置routeType参数进行页面跳转时，触发以下错误并导致页面黑屏：Summary by CodeRabbit