Skip to content

Fix unmet hours calculation when using on/off thermostat deadband model #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shorowit merged 2 commits into from
Apr 13, 2026
Merged

Fix unmet hours calculation when using on/off thermostat deadband model #2191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8f4ee
Fix use of deadband in unmet hours calculation; add tolerance.
shorowit Apr 9, 2026
1cc0933
Latest results.
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>15c39750-5947-45ef-887d-47606442ed57</version_id>
<version_modified>2026-04-02T19:46:00Z</version_modified>
<version_id>bf9d7070-c3d0-4251-ad9d-e45da9629d51</version_id>
<version_modified>2026-04-09T03:47:56Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -499,7 +499,7 @@
<filename>output.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>7F8E008D</checksum>
<checksum>2712B090</checksum>
</file>
<file>
<filename>psychrometrics.rb</filename>
Expand Down
7 changes: 5 additions & 2 deletions HPXMLtoOpenStudio/resources/output.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ def self.apply_unmet_hours_ems_program(model, hpxml_osm_map, hpxml_header)
htg_avail_sensor = model.getEnergyManagementSystemSensors.find { |s| s.additionalProperties.getFeatureAsString('ObjectType').to_s == Constants::ObjectTypeHeatingAvailabilitySensor }
clg_avail_sensor = model.getEnergyManagementSystemSensors.find { |s| s.additionalProperties.getFeatureAsString('ObjectType').to_s == Constants::ObjectTypeCoolingAvailabilitySensor }

htg_tol = model.getOutputControlReportingTolerances.toleranceforTimeHeatingSetpointNotMet
clg_tol = model.getOutputControlReportingTolerances.toleranceforTimeCoolingSetpointNotMet

# EMS program
clg_hrs = 'clg_unmet_hours'
htg_hrs = 'htg_unmet_hours'
Expand All @@ -151,7 +154,7 @@ def self.apply_unmet_hours_ems_program(model, hpxml_osm_map, hpxml_header)
line += " && (#{htg_avail_sensor.name} == 1)" if not htg_avail_sensor.nil?
program.addLine(line)
if zone_air_temp_sensors.keys.include? unit # on off deadband
program.addLine(" If #{zone_air_temp_sensors[unit].name} < (#{htg_spt_sensors[unit].name} - #{UnitConversions.convert(onoff_deadbands, 'deltaF', 'deltaC')})")
program.addLine(" If #{zone_air_temp_sensors[unit].name} < (#{htg_spt_sensors[unit].name} - #{htg_tol})")
Comment on lines -154 to +157
Copy link
Copy Markdown
Contributor Author

@shorowit shorowit Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While inspecting the results for base-hvac-air-to-air-heat-pump-1-speed-research-features.xml, I found that the indoor temperature was being compared to 61F. The heating setpoint is 64F and the deadband is 2F, so it should be compared to 63F. (Or, really, 63F minus the reporting tolerance of 0.2 deg-C.)

Copy link
Copy Markdown
Contributor Author

@shorowit shorowit Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example from another EMS program that shows the lower end of the heating setpoint is the schedule value:

OpenStudio-HPXML/HPXMLtoOpenStudio/resources/hvac.rb

Lines 3450 to 3451 in 209c72c

supp_coil_avail_program.addLine(" Set htg_sp_l = #{htg_sp_ss.name}")
supp_coil_avail_program.addLine(" Set htg_sp_h = #{htg_sp_ss.name} + #{ddb}")

Copy link
Copy Markdown
Collaborator

@yzhou601 yzhou601 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, good catch, the previous approach is wrong because we already shifted the schedule by 1/2 deadband so that the htg_spt_sensors will give 63F (cut-in) instead of cut-out, so applying full deadband here is causing issues.

program.addLine(" Set #{unit_htg_hrs} = #{unit_htg_hrs} + #{htg_sensors[unit].name}")
program.addLine(' EndIf')
else
Expand All @@ -173,7 +176,7 @@ def self.apply_unmet_hours_ems_program(model, hpxml_osm_map, hpxml_header)
line += " && (#{clg_avail_sensor.name} == 1)" if not clg_avail_sensor.nil?
program.addLine(line)
if zone_air_temp_sensors.keys.include? unit # on off deadband
program.addLine(" If #{zone_air_temp_sensors[unit].name} > (#{clg_spt_sensors[unit].name} + #{UnitConversions.convert(onoff_deadbands, 'deltaF', 'deltaC')})")
program.addLine(" If #{zone_air_temp_sensors[unit].name} > (#{clg_spt_sensors[unit].name} + #{clg_tol})")
program.addLine(" Set #{unit_clg_hrs} = #{unit_clg_hrs} + #{clg_sensors[unit].name}")
program.addLine(' EndIf')
else
Expand Down
4 changes: 2 additions & 2 deletions workflow/tests/base_results/results_simulations_misc.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,11 @@ base-hvac-air-to-air-heat-pump-1-speed-detailed-performance.xml,0.0,0.0,0.0,1286
base-hvac-air-to-air-heat-pump-1-speed-heating-capacity-17f.xml,0.0,0.0,0.0,1286.4,890.5,11468.5,3942.3,9035.1,4233.1,9035.1,9035.1,4233.1,9035.1,31072.0,24785.0,0.0
base-hvac-air-to-air-heat-pump-1-speed-heating-only.xml,0.0,0.0,0.0,1286.4,890.5,11468.6,3942.3,9046.3,1887.6,9046.3,9046.3,1887.6,9046.3,31055.0,0.0,0.0
base-hvac-air-to-air-heat-pump-1-speed-lockout-temperatures.xml,148.0,0.0,0.0,1286.4,890.5,11468.6,3942.3,15409.2,4217.6,15409.2,15409.2,4217.6,15409.2,51750.0,24621.0,0.0
base-hvac-air-to-air-heat-pump-1-speed-research-features.xml,250.567,0.0,0.0,1286.4,890.5,12241.8,4208.1,20808.8,9769.5,20808.8,20808.8,9769.5,20808.8,63178.0,33162.0,0.0
base-hvac-air-to-air-heat-pump-1-speed-research-features.xml,412.433,0.0,0.0,1286.4,890.5,12241.8,4208.1,20808.8,9769.5,20808.8,20808.8,9769.5,20808.8,63178.0,33162.0,0.0
Comment thread
shorowit marked this conversation as resolved.
base-hvac-air-to-air-heat-pump-1-speed-seer-hspf.xml,0.0,0.0,0.0,1286.4,890.5,11468.5,3942.3,9099.4,4416.8,9099.4,9099.4,4416.8,9099.4,31054.0,24785.0,0.0
base-hvac-air-to-air-heat-pump-1-speed.xml,0.0,0.0,0.0,1286.4,890.5,11468.5,3942.3,9063.9,4233.1,9063.9,9063.9,4233.1,9063.9,31054.0,24785.0,0.0
base-hvac-air-to-air-heat-pump-2-speed-detailed-performance.xml,0.0,0.0,0.0,1286.4,890.5,11468.5,3942.3,8970.5,4139.6,8970.5,8970.5,4139.6,8970.5,31065.0,26551.0,0.0
base-hvac-air-to-air-heat-pump-2-speed-research-features.xml,113.483,0.0,0.0,1286.4,890.5,12241.8,4208.1,20428.5,8271.9,20428.5,20428.5,8271.9,20428.5,61169.0,24149.0,0.0
base-hvac-air-to-air-heat-pump-2-speed-research-features.xml,371.3,0.0,0.0,1286.4,890.5,12241.8,4208.1,20428.5,8271.9,20428.5,20428.5,8271.9,20428.5,61169.0,24149.0,0.0
base-hvac-air-to-air-heat-pump-2-speed.xml,0.0,0.0,0.0,1286.4,890.5,11468.5,3942.3,9006.7,3885.5,9006.7,9006.7,3885.5,9006.7,31037.0,26784.0,0.0
base-hvac-air-to-air-heat-pump-var-speed-autosize-maxload.xml,0.0,0.0,0.0,1286.4,890.5,11468.5,3942.3,6255.1,3407.2,6255.1,6255.1,3407.2,6255.1,29024.0,24805.0,0.0
base-hvac-air-to-air-heat-pump-var-speed-backup-boiler-hvac-seasons.xml,3.0,460.0,0.0,1286.4,890.5,11468.6,3942.3,3285.6,3239.0,3285.6,3285.6,3239.0,3285.6,26537.0,18943.0,0.0
Expand Down