Fix unmet hours calculation when using on/off thermostat deadband model#2191
Fix unmet hours calculation when using on/off thermostat deadband model#2191
Conversation
| program.addLine(" If #{zone_air_temp_sensors[unit].name} < (#{htg_spt_sensors[unit].name} - #{UnitConversions.convert(onoff_deadbands, 'deltaF', 'deltaC')})") | ||
| program.addLine(" If #{zone_air_temp_sensors[unit].name} < (#{htg_spt_sensors[unit].name} - #{htg_tol})") |
There was a problem hiding this comment.
While inspecting the results for base-hvac-air-to-air-heat-pump-1-speed-research-features.xml, I found that the indoor temperature was being compared to 61F. The heating setpoint is 64F and the deadband is 2F, so it should be compared to 63F. (Or, really, 63F minus the reporting tolerance of 0.2 deg-C.)
There was a problem hiding this comment.
Here's an example from another EMS program that shows the lower end of the heating setpoint is the schedule value:
OpenStudio-HPXML/HPXMLtoOpenStudio/resources/hvac.rb
Lines 3450 to 3451 in 209c72c
There was a problem hiding this comment.
Interesting, good catch, the previous approach is wrong because we already shifted the schedule by 1/2 deadband so that the htg_spt_sensors will give 63F (cut-in) instead of cut-out, so applying full deadband here is causing issues.
shorowit
changed the title
3 participants
Pull Request Description
Noticed while working on #2189. Also adds the reporting tolerance for consistency with non-deadband simulations.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run