Skip to content

More robust feature-checking. #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

More robust feature-checking. #1528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/stdexec/__detail/__config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ namespace stdexec {
# define STDEXEC_HAS_STD_MEMORY_RESOURCE() 0
#endif

#if STDEXEC_HAS_FEATURE(__cpp_lib_execution)
#if defined(__cpp_lib_execution)
# define STDEXEC_HAS_EXECUTION_POLICY() 0
#elif STDEXEC_HAS_FEATURE(__cpp_lib_execution)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've seen the issue before the fix :(
I did post a possible fix in #1559.

Besides the problem reported in the issue, we also need to check the version of the feature flag, as the execution policies were added in 2 steps.

# define STDEXEC_HAS_EXECUTION_POLICY() 1
#else
# define STDEXEC_HAS_EXECUTION_POLICY() 0
Expand Down