More robust feature-checking. #1528
Conversation
|
Your patch seems to do the logical opposite of what I think you intend: if the feature exists, you don't use it. |
i don't think 0242ad9 was aimed at adding support for this on libstdc++-based builds, so here, as a quick fix i just wanted to make sure these still are able to build (not add support for this, since then i'd have to fix the underlying build failure, and i didn't have time for that). |
|
this seems wrong to me. @lucteo thoughts? |
jehelset
force-pushed
the
jeh/lib-execution-feature-check
branch
from
175a923 to
3cac235
Compare
|
It would be great if we find some solution to this, as the main branch currently does not compile on gcc-15. |
|
Sorry, I've missed this. These days are a bit busy for me, but I'll look as soon as I have some time. |
| #if STDEXEC_HAS_FEATURE(__cpp_lib_execution) | ||
| #if defined(__cpp_lib_execution) | ||
| # define STDEXEC_HAS_EXECUTION_POLICY() 0 | ||
| #elif STDEXEC_HAS_FEATURE(__cpp_lib_execution) |
There was a problem hiding this comment.
Sorry, I've seen the issue before the fix :(
I did post a possible fix in #1559.
Besides the problem reported in the issue, we also need to check the version of the feature flag, as the execution policies were added in 2 steps.
Suggestion for closing #1523.