Skip to content

Skip header check for merge to main PR #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Skip header check for merge to main PR #28

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8718456
skip header check for merge to main
YanxuanLiu Feb 18, 2025
b1e899d
change regex pattern
YanxuanLiu Feb 18, 2025
95e2048
update regex
YanxuanLiu Feb 18, 2025
e74b2b0
test regex
YanxuanLiu Feb 18, 2025
5750455
correct syntax
YanxuanLiu Feb 18, 2025
d53a373
update echo info
YanxuanLiu Feb 18, 2025
865e646
check base branch but not pr title
YanxuanLiu Feb 19, 2025
10fbcfd
base ref
YanxuanLiu Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions license-header-check/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ runs:
# Get license pattern with year
CURRENT_YEAR=$(date +%Y)
LICENSE_PATTERN="Copyright \(c\) .*?${CURRENT_YEAR},? NVIDIA CORPORATION."

# Skip for merge to main
PR_TITLE="${{ github.event.pull_request.title }}"
Copy link
Member

@pxLi pxLi Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check title is not promising and could cause some issue, can we do the check based on the PR.base?

Copy link
Collaborator Author

@YanxuanLiu YanxuanLiu Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changed to use base.ref

PR_TITLE_REGEX="^Merge branch-[0-9]+.[0-9]+ into main"
if [[ $PR_TITLE =~ $PR_TITLE_REGEX ]]; then
echo "Skip this check for Merge to main PR."
exit 0
fi

# Format file patterns
IFS="," read -r -a INCLUDE_PATTERNS <<< "$(echo "${{ inputs.included_file_patterns }}" | tr -d ' ' | tr -d '\n')"
Expand Down