Skip header check for merge to main PR #28
Conversation
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
license-header-check/action.yml
Outdated
| LICENSE_PATTERN="Copyright \(c\) .*?${CURRENT_YEAR},? NVIDIA CORPORATION." | ||
| # Skip for merge to main | ||
| PR_TITLE="${{ github.event.pull_request.title }}" |
There was a problem hiding this comment.
check title is not promising and could cause some issue, can we do the check based on the PR.base?
There was a problem hiding this comment.
Yes, changed to use base.ref
Signed-off-by: Yanxuan Liu <[email protected]>
Signed-off-by: Yanxuan Liu <[email protected]>
license-header-check/action.yml
Outdated
| LICENSE_PATTERN="Copyright \(c\) .*?${CURRENT_YEAR},? NVIDIA CORPORATION." | ||
| # Skip for merge to main PR | ||
| if [[ "${{ github.event.pull_request.base.sha }}" == "main" ]]; then |
There was a problem hiding this comment.
Im not sure, sha could be the actual commit id, may try .ref
There was a problem hiding this comment.
changed to base.ref. test run: https://github.com/YanxuanLiu/spark-rapids/actions/runs/13404579617/job/37442083494?pr=22#step:4:33
There was a problem hiding this comment.
do we have a target main run log? thanks
There was a problem hiding this comment.
https://github.com/YanxuanLiu/spark-rapids/actions/runs/13404579617/job/37442083494?pr=24#step:4:33 it still got branch-25.02 since the feature branch is based on branch-25.02
There was a problem hiding this comment.
then we could try pass the ENV from caller side or try find some other event property for this case
There was a problem hiding this comment.
I am checking your test vars, it seems this commit check status has been override by previous run
There was a problem hiding this comment.
Corrected the commit history of forked repo and tested again, now it can get correct base.ref https://github.com/YanxuanLiu/spark-rapids/actions/runs/13406205693/job/37446469023?pr=25
|
updated with latest run: https://github.com/YanxuanLiu/spark-rapids/actions/runs/13406205693 previous test failure was false alarm due to common commits in 2 alive PRs |
2 participants
fix #27
Test run: https://github.com/YanxuanLiu/spark-rapids/actions/runs/13388432338/job/37390380186?pr=22