Generate CDI specs for coherent and non-coherent devices

[elezar]

This change updates CDI spec generation to generation specifications for coherent and non-coherent devices. At its core, this is acheived by adding device-level annotations to the CDI specification for devices indicating whether a device is coherent or not. The nvidia-ctk cdi generate command then splits the generated spec by the specified annotation and generates additional specs for nvidia.com/gpu.coherent and / or nvidia.com/gpu.noncoherentdevices.

For example, when running on a device that supports coherence we see the following:

$ ./nvidia-ctk cdi generate --output $(pwd)/test/nvidia.yaml
$ ls -l test/
total 48
-rw-r--r-- 1 local-elezar local-elezar 20820 Aug 15 13:22 nvidia.coherent.yaml
-rw-r--r-- 1 local-elezar local-elezar 20811 Aug 15 13:22 nvidia.yaml

With the only difference between the two specs being the device kind:

$ diff test/nvidia.yaml test/nvidia.coherent.yaml
3c3
< kind: nvidia.com/gpu
---

The following specs are generated:

$ nvidia-ctk cdi list --spec-dir=$(pwd)/test/
INFO[0000] Found 6 CDI devices
nvidia.com/gpu.coherent=0
nvidia.com/gpu.coherent=GPU-ca81aac1-36e7-2d26-8a15-0aa6ef17c627
nvidia.com/gpu.coherent=all
nvidia.com/gpu=0
nvidia.com/gpu=GPU-ca81aac1-36e7-2d26-8a15-0aa6ef17c627
nvidia.com/gpu=all

This is blocked by:

• Bump to NVML version 13.0 go-nvml#156
• Add IsCoherent API to Device type go-nvlib#68

[Copilot]

Pull Request Overview

This PR implements the generation of separate CDI specifications for coherent and non-coherent GPU devices. The implementation adds device-level annotations to indicate coherence status and splits the generated CDI spec accordingly.

• Adds coherence annotations to GPU device specifications
• Generates separate CDI specs for coherent/non-coherent devices in addition to the base spec
• Introduces feature flag to control coherence annotation behavior

Reviewed Changes

Copilot reviewed 9 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/nvcdi/options.go	Adds WithFeatureFlags function and deprecates single WithFeatureFlag
pkg/nvcdi/api.go	Defines new FeatureDisableCoherentAnnotations feature flag
pkg/nvcdi/full-gpu-nvml.go	Implements device coherence annotation logic
pkg/nvcdi/lib-nvml.go	Updates function calls to pass feature flags
pkg/nvcdi/mig-device-nvml.go	Disables coherent annotations for MIG devices
cmd/nvidia-ctk/cdi/generate/generate.go	Implements spec splitting logic and multi-spec generation
cmd/nvidia-ctk/cdi/generate/generate_test.go	Updates tests for new multi-spec generation
deployments/devel/go.mod	Removes golangci-lint dependency
deployments/devel/tools.go	Removes golangci-lint import

---

_{You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[elezar]

We should add an attribute to the k8s-dra-driver for this too.

[jgehrcke]

This is a 'trust approval', in case you need to move forward for the next release candidate. I am not sure if we have consensus in the team to use these types of approvals -- but I personally think that sometimes there's a time for them (very open to discussing this arguably controversial perspective).

[ArangoGutierrez]

lgtm

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[ArangoGutierrez]

/ok to test

[guptaNswati]

Is this supposed to be supported with device-plugin as well.