Disable generation of nvidia.com/gpu.[non]coherent CDI specs by default #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
changed the title
This change disables the functionality for splitting generated CDI specifications based on device coherence by default. This was added in NVIDIA#1247, but due to discussions around whether coherence is an property that should be exposed, we are disabling this by default. Note that users can opt in to the feature by running the `nvidia-ctk cdi generate` with the `--feature-flag=enable-coherent-annotations` command line flag. Alternatively the `nvidia-ctk cdi generate` command can be run with the `NVIDIA_CTK_CDI_GENERATE_FEATURE_FLAGS` enviroment set to include "enable-coherent-annotations" (in a comma-separated list). Signed-off-by: Evan Lezar <[email protected]>
elezar
changed the title
ArangoGutierrez
approved these changes
Sep 26, 2025
klueska
approved these changes
Sep 26, 2025
Contributor
klueska
left a comment
klueska
left a comment
There was a problem hiding this comment.
What was the primary motivation for the change in semantics?
Member
Author
As noted in the description:
With regards to what constitutes coherence, it was called out after the initial implementation that HMM addressing mode is not actually coherent. This was initially included due to an incorrect requirement in the original request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change bumps the
github.com/NVIDIA/go-nvlibdependency fromv0.8.0tov0.8.1to ensures thatnvidia.com/gpu.coherentCDI specs are only generated for devices with an addressing mode of ATS.It also disables the functionality for splitting generated CDI specifications based on device coherence by default. This was added in #1247, but due to discussions around whether coherence is an property that should be exposed, we are disabling this by default.
Note that users can opt in to the feature by running the
nvidia-ctk cdi generatewith the--feature-flag=enable-coherent-annotationscommand line flag. Alternatively thenvidia-ctk cdi generatecommand can be run with theNVIDIA_CTK_CDI_GENERATE_FEATURE_FLAGSenviroment set to include"enable-coherent-annotations"(in a comma-separated list).The same feature flag can be passed to the
nvcdiAPI when constructing a CDI spec generator.