Invalidate go build cache layer less often #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
Collaborator
Author
|
(done as part of working on #389, removing this patch from there) |
jgehrcke
commented
Jun 10, 2025
| WORKDIR /build | ||
| COPY . . | ||
|
|
||
| # Copy everything that is needed for the go build, but do not invalidate go |
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
elezar
approved these changes
Jun 26, 2025
Collaborator
Author
|
Thanks for having had a look @elezar! Let's land this, and learn as we go. Not very attached to this particular way of doing things -- I just think it's worth making some kind of progress now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go build takes slightly more than one minute on my machine, and about ~30 seconds on a fast multi-core box. The go build contributes almost 100 % to the image build time.
It's currently triggered when changing any file in the build context because we
COPY . .before invoking the build.This is of course useful in order to make sure we never accidentally don't invalidate. As we all know... missing cache invalidation can be one of the most annoying things.
But I think we should work towards a trade-off here. Mutation of certain files (think: allow-listing) should not invalidate the go build cache layer.
This comes from the perspective of rebuilding at high frequency during local dev / bisection / debugging / dev.