Fix COPYing files during container image build #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgehrcke
force-pushed
the
jp/container-img-fix-copying-files
branch
from
e6c7b57 to
7a9304a
Compare
klueska
reviewed
Jul 3, 2025
deployments/container/Dockerfile
Outdated
Comment on lines
105
to
107
| COPY /hack/kubelet-plugin-prestart.sh /usr/bin/kubelet-plugin-prestart.sh | ||
| COPY /templates /templates | ||
|
|
Collaborator
There was a problem hiding this comment.
Can we do this last -- also if we are separating them into "groups", then there should be a newline after copy from the toolkit stage, before the copy from the build stage. Otherwise, just smash them all together.
Collaborator
Author
There was a problem hiding this comment.
Otherwise, just smash them all together.
done
jgehrcke
force-pushed
the
jp/container-img-fix-copying-files
branch
from
7a9304a to
73ee099
Compare
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
jgehrcke
force-pushed
the
jp/container-img-fix-copying-files
branch
from
ac6cac4 to
9c355f8
Compare
klueska
approved these changes
Jul 3, 2025
elezar
approved these changes
Jul 3, 2025
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this error in a PR:
logs
#397 introduced that problem, partly because I started working on it before landing #389.
The last CI run on #379 wasn't quite authoritative.