Skip to content

Remove needless arg from container/Dockerfile #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Remove needless arg from container/Dockerfile #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deployments/container/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG GOLANG_VERSION=1.24.2
# We use an ubuntu20.04 base image to allow for a more efficient multi-arch builds.
FROM nvcr.io/nvidia/cuda:12.8.1-base-ubuntu20.04 AS build

Expand All @@ -21,6 +20,7 @@ RUN apt-get update && \
&& \
rm -rf /var/lib/apt/lists/*

# Require build arg.
ARG GOLANG_VERSION=x.x.x

RUN set -eux; \
Expand All @@ -35,8 +35,8 @@ RUN set -eux; \
wget -nv -O - https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-${ARCH}.tar.gz \
| tar -C /usr/local -xz

ENV GOPATH /go
ENV PATH $GOPATH/bin:/usr/local/go/bin:$PATH
ENV GOPATH=/go
ENV PATH=$GOPATH/bin:/usr/local/go/bin:$PATH
Copy link
Collaborator Author

@jgehrcke jgehrcke May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(noop change, that was just my local Dockerfile linter complaining)


WORKDIR /build
COPY . .
Expand Down