Remove needless arg from container/Dockerfile

[jgehrcke]

This change removes a (by now) superfluous arg. The removal simplifies dependabot-automated Golang bumps.

Note that GOLANG_VERSION is injected (based on the current source of truth) when invoking for example make -f deployments/container/Makefile build.

Connecting dots: #324 (comment)

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[Copilot]

Pull Request Overview

This PR removes a superfluous default ARG from the Dockerfile to simplify automated Golang version bumps by depending on an externally provided value. The changes include removing the hardcoded GOLANG_VERSION during the build stage, explicitly requiring the build argument, and standardizing ENV variable syntax.

Comments suppressed due to low confidence (1)

deployments/container/Dockerfile:24

• The placeholder value 'x.x.x' for GOLANG_VERSION may lead to unintended behavior if not overridden. Consider updating the placeholder or adding a clarifying comment to ensure it's always injected via the build system.

ARG GOLANG_VERSION=x.x.x

[jgehrcke]

(noop change, that was just my local Dockerfile linter complaining)

[elezar]

Does this also require changes to the README or do we not document building using the Dockerfile directly?

[guptaNswati]

Does this also require changes to the README or do we not document building using the Dockerfile directly?

We don't. We only document using the scripts.