Build with Go 1.23.8, update image metadata #324
Conversation
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
| # This Dockerfile is also used to define the golang version used in this project | ||
| # This allows dependabot to manage this version in addition to other images. | ||
| FROM golang:1.23.1 | ||
| FROM golang:1.23.8 |
There was a problem hiding this comment.
Since we're still on main, this is done by #312 I'm OK to do this here.
There was a problem hiding this comment.
this is done by #312 I'm OK to do this here.
Right. This PR here is slightly more conservative as it stays within 1.23.x
There was a problem hiding this comment.
Yes, in other projects we configure dependabot to only allow patch updates on release-* branches. This would have skipped these minor version updates.
| # limitations under the License. | ||
|
|
||
| ARG GOLANG_VERSION=1.23.1 | ||
| ARG GOLANG_VERSION=1.23.8 |
There was a problem hiding this comment.
It should be possible to drop this here. I know that sometimes we allow users to build the dockerfiles directly from the git repos, but setting this to:
| ARG GOLANG_VERSION=1.23.8 | |
| ARG GOLANG_VERSION=undefined |
Should give a reasonable error message when a user does not provide the expected --build-arg.
I don't think the effort in maintaining support for this out-of-band build process is worth the benefit to the community.
There was a problem hiding this comment.
Thanks! I will leave things as they are for now, and we can perform that simplification later.
| LABEL org.opencontainers.image.description "NVIDIA GPU DRA driver for Kubernetes" | ||
| LABEL summary="NVIDIA DRA Driver for GPUs" | ||
| LABEL description="NVIDIA DRA Driver for GPUs" | ||
| LABEL org.opencontainers.image.description "NVIDIA DRA Driver for GPUs" |
There was a problem hiding this comment.
| LABEL org.opencontainers.image.description "NVIDIA DRA Driver for GPUs" | |
| LABEL org.opencontainers.image.description="NVIDIA DRA Driver for GPUs" |
There was a problem hiding this comment.
On Dockerfiles is valid to have Label Key Val separated without an =
There was a problem hiding this comment.
Thanks! Let's normalize this later, and then pick the preferred way of doing this (if one of both is preferred).
There was a problem hiding this comment.
On Dockerfiles is valid to have Label Key Val separated without an =
Yes, I'm not saying it's invalid. I'm saying that it's locally inconsistent. Not a blocker for this PR though.
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
Minor nits / comments. No blockers for this PR.
github-project-automation
bot
moved this to Backlog
in Planning Board: k8s-dra-driver-gpu
4 participants
Quick proposal for two unrelated and minor maintenance changes:
Note: we currently don't have a source of truth for the Go version, and need to update it in two places.
./hack/golang-version.shconsultsdeployments/devel/Dockerfile.