Skip to content

Bump version to 25.3.0-rc.2, clean up Helm chart.yaml #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Bump version to 25.3.0-rc.2, clean up Helm chart.yaml #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions deployments/helm/nvidia-dra-driver-gpu/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,32 +15,14 @@

apiVersion: v2
name: nvidia-dra-driver-gpu
description: Official Helm chart for the Kubernetes DRA driver for NVIDIA GPUs

# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
# to be deployed.
#
# Library charts provide useful utilities or functions for the chart developer. They're included as
# a dependency of application charts to inject those utilities and functions into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
Comment on lines -20 to -27
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing helm init comments ++ Approved!

description: Official Helm chart for the NVIDIA DRA Driver for GPUs
type: application

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

# Note(JP): no v prefix allowed
version: 25.3.0-rc.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
# Note(JP): strict semver: no v prefix allowed
version: "25.3.0-rc.2"

# Note(jgehrcke): templating logic consumes `appVersion` for building the default
# Note(JP): templating logic consumes `appVersion` for building the default
Copy link
Collaborator Author

@jgehrcke jgehrcke Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benevolent reader (likely one of us) who actually wonders "who's ramblings are that?" already knows, or finds the answer anyway. Personalizing comments is a valuable cultural habit I picked up elsewhere, and it's an added-bonus that should not adhere to rules. (also: I want to type less).

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be in favor of jgehrcke that way in the Git history of the project we save it with your git account

# `tag` value used in a k8s image specification. That logic expects the version
# number below to not have a "v" prefix (a "v" is added by said logic to yield a
# valid image reference).
appVersion: "25.3.0-rc.1"
appVersion: "25.3.0-rc.2"
2 changes: 1 addition & 1 deletion versions.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ MODULE := github.com/NVIDIA/$(DRIVER_NAME)

REGISTRY ?= nvcr.io/nvidia

VERSION ?= v25.3.0-rc.1
VERSION ?= v25.3.0-rc.2

# vVERSION represents the version with a guaranteed v-prefix
# Note: this is probably not consumed in our build chain.
Expand Down