-
Notifications
You must be signed in to change notification settings - Fork 99
Bump version to 25.3.0-rc.2, clean up Helm chart.yaml #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
| version: "25.3.0-rc.2" | ||
|
|
||
| # Note(jgehrcke): templating logic consumes `appVersion` for building the default | ||
| # Note(JP): templating logic consumes `appVersion` for building the default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The benevolent reader (likely one of us) who actually wonders "who's ramblings are that?" already knows, or finds the answer anyway. Personalizing comments is a valuable cultural habit I picked up elsewhere, and it's an added-bonus that should not adhere to rules. (also: I want to type less).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be in favor of jgehrcke that way in the Git history of the project we save it with your git account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version and cleans up the Helm Chart.yaml file for the NVIDIA DRA Driver for GPUs release candidate.
- Updated the description to use the product name "NVIDIA DRA Driver for GPUs".
- Bumped the chart version and appVersion from 25.3.0-rc.1 to 25.3.0-rc.2.
- Removed outdated comments and updated note attribution for consistency.
Files not reviewed (1)
- versions.mk: Language not supported
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # A chart can be either an 'application' or a 'library' chart. | ||
| # | ||
| # Application charts are a collection of templates that can be packaged into versioned archives | ||
| # to be deployed. | ||
| # | ||
| # Library charts provide useful utilities or functions for the chart developer. They're included as | ||
| # a dependency of application charts to inject those utilities and functions into the rendering | ||
| # pipeline. Library charts do not define any templates and therefore cannot be deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing helm init comments ++ Approved!
Why? This is not a tag.. :) It is just preparing the next release (and in the future we should adopt a -devel or -dev approach to make this difference more explicit). |
Changes are incoming for a second release candidate.
Now that I understand a little more about Helm charts I have taken liberty to clean up the Chart.yaml a bit, and to also Helm chart description to use the name we picked: "NVIDIA DRA Driver for GPUs".