Skip to content

Conversation

@jgehrcke
Copy link
Collaborator

Changes are incoming for a second release candidate.

Now that I understand a little more about Helm charts I have taken liberty to clean up the Chart.yaml a bit, and to also Helm chart description to use the name we picked: "NVIDIA DRA Driver for GPUs".

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

version: "25.3.0-rc.2"

# Note(jgehrcke): templating logic consumes `appVersion` for building the default
# Note(JP): templating logic consumes `appVersion` for building the default
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benevolent reader (likely one of us) who actually wonders "who's ramblings are that?" already knows, or finds the answer anyway. Personalizing comments is a valuable cultural habit I picked up elsewhere, and it's an added-bonus that should not adhere to rules. (also: I want to type less).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be in favor of jgehrcke that way in the Git history of the project we save it with your git account

@ArangoGutierrez ArangoGutierrez requested a review from Copilot March 26, 2025 13:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version and cleans up the Helm Chart.yaml file for the NVIDIA DRA Driver for GPUs release candidate.

  • Updated the description to use the product name "NVIDIA DRA Driver for GPUs".
  • Bumped the chart version and appVersion from 25.3.0-rc.1 to 25.3.0-rc.2.
  • Removed outdated comments and updated note attribution for consistency.
Files not reviewed (1)
  • versions.mk: Language not supported

@ArangoGutierrez ArangoGutierrez requested a review from klueska March 26, 2025 13:42
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should wait for #300 and #298

Comment on lines -20 to -27
# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
# to be deployed.
#
# Library charts provide useful utilities or functions for the chart developer. They're included as
# a dependency of application charts to inject those utilities and functions into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing helm init comments ++ Approved!

@jgehrcke
Copy link
Collaborator Author

This PR should wait for ...

Why? This is not a tag.. :) It is just preparing the next release (and in the future we should adopt a -devel or -dev approach to make this difference more explicit).

@jgehrcke jgehrcke merged commit c1c2977 into NVIDIA:main Mar 26, 2025
7 checks passed
@klueska klueska added this to the v25.3.0 milestone Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants