Skip to content

Bump terminationGracePeriodSeconds to 120 for vGPU Manager daemonset #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Bump terminationGracePeriodSeconds to 120 for vGPU Manager daemonset #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/state-vgpu-manager/0500_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
labels:
app: nvidia-vgpu-manager-daemonset
spec:
terminationGracePeriodSeconds: 120
nodeSelector:
nvidia.com/gpu.deploy.vgpu-manager: "true"
tolerations:
Expand Down
1 change: 1 addition & 0 deletions internal/state/testdata/golden/driver-vgpu-host-manager-openshift.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ spec:
nvidia.com/gpu.deploy.vgpu-manager: "true"
priorityClassName: system-node-critical
serviceAccountName: nvidia-vgpu-manager-openshift
terminationGracePeriodSeconds: 120
tolerations:
- effect: NoSchedule
key: nvidia.com/gpu
Expand Down
1 change: 1 addition & 0 deletions internal/state/testdata/golden/driver-vgpu-host-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ spec:
nvidia.com/gpu.deploy.vgpu-manager: "true"
priorityClassName: system-node-critical
serviceAccountName: nvidia-vgpu-manager-ubuntu22.04
terminationGracePeriodSeconds: 120
tolerations:
- effect: NoSchedule
key: nvidia.com/gpu
Expand Down
3 changes: 3 additions & 0 deletions manifests/state-driver/0500_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ spec:
{{- .Driver.Spec.Labels | yaml | nindent 8 }}
{{- end }}
spec:
{{- if eq .Driver.Spec.DriverType "vgpu-host-manager" }}
terminationGracePeriodSeconds: 120
{{- end }}
nodeSelector:
{{- if eq .Driver.Spec.DriverType "vgpu-host-manager" }}
nvidia.com/gpu.deploy.vgpu-manager: "true"
Expand Down
Loading