Bump terminationGracePeriodSeconds to 120 for vGPU Manager daemonset #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the vGPU Manager has enough time to finish its cleanup logic when the pod is terminated. This fixes an issue observed on a HGX node (with 8 GPUs) where the vGPU Manager was killed before it finished disabling VFs on all 8 GPUs. Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
requested review from
ArangoGutierrez,
elezar,
shivamerla and
tariq1890
as code owners
tariq1890
reviewed
Oct 21, 2025
tariq1890
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the vGPU Manager has enough time to finish its cleanup logic when the pod is terminated. This fixes an issue observed on a HGX node (with 8 GPUs) where the vGPU Manager was killed before it finished disabling VFs on all 8 GPUs.