Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ubuntu24.04/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM nvcr.io/nvidia/cuda:13.0.0-base-ubuntu24.04 as build
ARG BASE_IMAGE=ubuntu:noble-20250716
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: will dependabot still be able to update this line now that it is not a FROM statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. It depends on dependabot's Dockerfile provider I suppose

Copy link
Contributor Author

@tariq1890 tariq1890 Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On doing a cursory lookup, it seems unlikely that dependabot would update any docker image reference other than one in a FROM statement. We'd have to use renovate to automate updates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the renovate job in a follow-up.


FROM ${BASE_IMAGE} as build

ARG TARGETARCH
ARG GOLANG_VERSION
Expand Down Expand Up @@ -34,7 +36,7 @@ RUN git clone https://github.com/NVIDIA/gpu-driver-container driver && \
go build -o vgpu-util && \
mv vgpu-util /work

FROM nvcr.io/nvidia/cuda:13.0.0-base-ubuntu24.04
FROM ${BASE_IMAGE}

SHELL ["/bin/bash", "-c"]

Expand Down Expand Up @@ -88,10 +90,4 @@ RUN if [ -n "${CVE_UPDATES}" ]; then \
rm -rf /var/lib/apt/lists/*; \
fi

# Remove cuda repository to avoid GPG errors
RUN rm -f /etc/apt/sources.list.d/cuda*

# Add NGC DL license from the CUDA image
RUN mkdir /licenses && mv /NGC-DL-CONTAINER-LICENSE /licenses/NGC-DL-CONTAINER-LICENSE

ENTRYPOINT ["nvidia-driver", "init"]
6 changes: 2 additions & 4 deletions ubuntu24.04/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ dep_install () {
curl \
kmod \
file \
gnupg \
libelf-dev \
libglvnd-dev \
pkg-config && \
Expand All @@ -29,17 +30,14 @@ dep_install () {
curl \
kmod \
file \
gnupg \
libelf-dev \
libglvnd-dev && \
rm -rf /var/lib/apt/lists/*
fi
}

setup_cuda_repo() {
# Remove any existing CUDA GPG keys that are unconditionally trusted by apt
apt-key del 3bf863cc
rm /etc/apt/sources.list.d/cuda.list

# Fetch public CUDA GPG key and configure apt to only use this key when downloading CUDA packages
OS_ARCH=${TARGETARCH/amd64/x86_64} && OS_ARCH=${OS_ARCH/arm64/sbsa};
curl -fSsL "https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2404/${OS_ARCH}/cuda-keyring_1.1-1_all.deb" -o cuda-keyring_1.1-1_all.deb
Expand Down