[ubuntu24.04] replace cuda base image in favour of upstream ubuntu image #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesiniotis
approved these changes
Aug 26, 2025
Signed-off-by: Tariq Ibrahim <[email protected]>
tariq1890
force-pushed
the
ubuntu-vanilla-base
branch
from
799440e to
29e9ab1
Compare
Contributor
Author
|
@cdesiniotis requesting another review. I have added a build arg to specify the base image, should we ever need to use a different one |
cdesiniotis
reviewed
Aug 27, 2025
| @@ -1,4 +1,6 @@ | |||
| FROM nvcr.io/nvidia/cuda:13.0.0-base-ubuntu24.04 as build | |||
| ARG BASE_IMAGE=ubuntu:noble-20250716 | |||
Contributor
There was a problem hiding this comment.
Question: will dependabot still be able to update this line now that it is not a FROM statement?
Contributor
Author
There was a problem hiding this comment.
I am not sure. It depends on dependabot's Dockerfile provider I suppose
Contributor
Author
There was a problem hiding this comment.
On doing a cursory lookup, it seems unlikely that dependabot would update any docker image reference other than one in a FROM statement. We'd have to use renovate to automate updates
Contributor
Author
There was a problem hiding this comment.
I'll add the renovate job in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.