fix(chart): scope CRD manager permissions to specific resource names #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restricts the RBAC permissions for the CRD manager by adding specific
resourceNamesto the ClusterRole, following the principle of least privilege. Instead of granting blanket permissions to all CustomResourceDefinitions, the CRD manager now only has permissions to manage the specific CRDs used by KAI Scheduler:configs.kai.schedulerschedulingshards.kai.schedulerbindrequests.scheduling.run.aipodgroups.scheduling.run.aiqueues.scheduling.run.aitopologies.kueue.x-k8s.ioThis change improves security by limiting the scope of permissions and reducing the potential attack surface.
Related Issues
Fixes #
Checklist
Breaking Changes
None. This change only restricts existing permissions to specific CRD resources, which should not affect normal operation since the CRD manager only needs to manage these specific CRDs.
Additional Notes
Security Consideration: This change follows Kubernetes RBAC best practices by scoping permissions to only the specific resources needed. The
resourceNamesfield ensures that the CRD manager service account can only interact with the explicitly listed CRDs, preventing potential unauthorized access to other CRDs in the cluster.