Skip to content

Conversation

@lokielse
Copy link
Contributor

@lokielse lokielse commented Nov 11, 2025

Description

This PR restricts the RBAC permissions for the CRD manager by adding specific resourceNames to the ClusterRole, following the principle of least privilege. Instead of granting blanket permissions to all CustomResourceDefinitions, the CRD manager now only has permissions to manage the specific CRDs used by KAI Scheduler:

  • configs.kai.scheduler
  • schedulingshards.kai.scheduler
  • bindrequests.scheduling.run.ai
  • podgroups.scheduling.run.ai
  • queues.scheduling.run.ai
  • topologies.kueue.x-k8s.io

This change improves security by limiting the scope of permissions and reducing the potential attack surface.

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated CHANGELOG.md (if needed)
  • Updated documentation (if needed)

Breaking Changes

None. This change only restricts existing permissions to specific CRD resources, which should not affect normal operation since the CRD manager only needs to manage these specific CRDs.

Additional Notes

Security Consideration: This change follows Kubernetes RBAC best practices by scoping permissions to only the specific resources needed. The resourceNames field ensures that the CRD manager service account can only interact with the explicitly listed CRDs, preventing potential unauthorized access to other CRDs in the cluster.

@enoodle enoodle changed the title fix(rbac): scope CRD manager permissions to specific resource names fix(chart): scope CRD manager permissions to specific resource names Nov 11, 2025
@enoodle enoodle merged commit 04351ed into NVIDIA:main Nov 11, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants