Skip to content

fix(studio): point agent Open traces button to Intake traces #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
walston merged 2 commits into from
Aug 14, 2026
+20 −8
Merged

fix(studio): point agent Open traces button to Intake traces #1292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dac551
fix(studio): point agent Open traces button to Intake traces
walston Aug 13, 2026
f373a30
fix(studio): use Traces (ListTree) icon on Open traces button
walston Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

vi.hoisted(() => {
vi.stubEnv('VITE_FF_MONITOR_ENABLED', 'true');
vi.stubEnv('VITE_FF_INTAKE_ENABLED', 'true');
});

import { ROUTES } from '@studio/constants/routes';
Expand All @@ -18,7 +18,10 @@ const workspace = workspace1.workspace;
const renderDetail = () =>
renderRoute(undefined, {
history: getAgentDetailRoute(workspace, agentName),
routes: [{ path: ROUTES.workspace.agentDetail, element: <AgentDetailRoute /> }],
routes: [
{ path: ROUTES.workspace.agentDetail, element: <AgentDetailRoute /> },
{ path: ROUTES.workspace.intakeTraces, element: <div>intake-traces-page</div> },
],
});

describe('AgentDetailRoute', () => {
Expand All @@ -42,6 +45,15 @@ describe('AgentDetailRoute', () => {
expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
});

it('navigates to intake traces when Open traces is clicked', async () => {
const user = userEvent.setup();
renderDetail();

await user.click(await screen.findByRole('button', { name: 'Open traces' }));

expect(await screen.findByText('intake-traces-page')).toBeInTheDocument();
});

it('switches to the chat tab', async () => {
const user = userEvent.setup();
renderDetail();
Expand Down
12 changes: 6 additions & 6 deletions web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
} from '@nvidia/foundations-react-core';
import { getAgentModelNames } from '@studio/components/dataViews/AgentsDataView/utils';
import { SubmitEvaluationModal } from '@studio/components/evaluation/SubmitEvaluationModal';
import { MONITOR_ENABLED } from '@studio/constants/environment';
import { INTAKE_ENABLED } from '@studio/constants/environment';
import { ROUTE_PARAMS } from '@studio/constants/routes';
import { useWorkspaceFromPath } from '@studio/hooks/useWorkspaceFromPath';
import { useBreadcrumbs } from '@studio/providers/breadcrumbs/useBreadcrumbs';
Expand All @@ -35,8 +35,8 @@ import {
clearAgentWalkthroughPending,
isAgentWalkthroughPending,
} from '@studio/routes/agents/AgentDetailRoute/walkthroughStorage';
import { getAgentMonitorRoute, getAgentsListRoute } from '@studio/routes/utils';
import { Activity, ClipboardCheck, Dot, Rocket } from 'lucide-react';
import { getAgentsListRoute, getIntakeTracesRoute } from '@studio/routes/utils';
import { ClipboardCheck, Dot, ListTree, Rocket } from 'lucide-react';
import { type FC, useEffect, useRef, useState } from 'react';
import { useNavigate, useParams, useSearchParams } from 'react-router';

Expand Down Expand Up @@ -164,9 +164,9 @@ export const AgentDetailRoute: FC = () => {
}
slotActions={
<Flex gap="2" wrap="wrap" justify="end">
{MONITOR_ENABLED && (
<Button kind="secondary" onClick={() => navigate(getAgentMonitorRoute(workspace))}>
<Activity className="size-4" aria-hidden />
{INTAKE_ENABLED && (
<Button kind="secondary" onClick={() => navigate(getIntakeTracesRoute(workspace))}>
<ListTree className="size-4" aria-hidden />
Open traces
</Button>
)}
Expand Down