Skip to content

fix(studio): point agent Open traces button to Intake traces - #1292

Open
walston wants to merge 2 commits into
mainfrom
nwalston/astd-402-agents-opening-traces-navigates-to-the-monitor-tab-instead
Open

fix(studio): point agent Open traces button to Intake traces#1292
walston wants to merge 2 commits into
mainfrom
nwalston/astd-402-agents-opening-traces-navigates-to-the-monitor-tab-instead

Conversation

@walston

@walston walston commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

The "Open traces" button on the agent detail page navigated to the Monitor tab (/agents/monitor) and was gated behind MONITOR_ENABLED, so with Monitor disabled it was hidden entirely. It now navigates to the Intake Traces route (/intake/traces) and is gated behind INTAKE_ENABLED, so it renders and links to Traces as intended.

Related Issue

ASTD-402: https://linear.app/nvidia/issue/ASTD-402

Changes

  • AgentDetailRoute/index.tsx: swap getAgentMonitorRoutegetIntakeTracesRoute and MONITOR_ENABLEDINTAKE_ENABLED for the "Open traces" button, and use the ListTree icon to match the AppBar Traces nav item (was Activity).
  • AgentDetailRoute/index.test.tsx: stub VITE_FF_INTAKE_ENABLED, and add a test asserting the button navigates to the Intake traces route.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with documentation updates
  • Documentation only
  • Contributor tooling or automation
  • CI, build, or test infrastructure

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Documentation updated for user-visible behavior
  • Documentation not applicable — justification: internal navigation link fix; no user-facing docs describe this button target.

Verification

  • Pull request title follows the repository's Conventional Commit format
  • Every commit includes an appropriate Signed-off-by: trailer
  • uv run pre-commit run -a passes, or any blocked checks are identified below
  • Targeted tests pass, or tests are marked not applicable above
  • No secrets, API keys, or credentials are included

Targeted validation:

  • pnpm --filter nemo-studio-ui exec vitest run src/routes/agents/AgentDetailRoute/index.test.tsx → 4 passed (incl. new navigation guard).
  • pnpm exec prettier --check on changed files → clean.
  • pnpm exec eslint on changed files → clean.
  • pnpm --filter nemo-studio-ui run typecheck → clean.
  • Commit-time pre-commit hooks (incl. DCO) passed on the changed files. Full uv run pre-commit run -a not run; change is web-only, and CI runs the full gate.

Summary by CodeRabbit

New Features

  • Updated the agent details page’s Open traces action to open the intake traces view.
  • Refreshed the traces icon to better represent the available trace hierarchy.
  • Enabled the intake experience for this workflow.

Tests

  • Added coverage confirming that Open traces navigates to the correct intake traces page.

The agent detail page Open traces button navigated to the Monitor tab
and was gated behind MONITOR_ENABLED. Retarget it to the Intake traces
route and gate on INTAKE_ENABLED so it renders and links to Traces.

Fixes ASTD-402

Signed-off-by: Nathan Walston <nwalston@nvidia.com>
@walston
walston requested review from a team as code owners August 13, 2026 19:48
@github-actions github-actions Bot added the fix label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0a3be325-777e-4894-bfda-8217be471105

📥 Commits

Reviewing files that changed from the base of the PR and between 3dac551 and f373a30.

📒 Files selected for processing (1)
  • web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx

📝 Walkthrough

Walkthrough

Changes

Agent intake traces navigation

Layer / File(s) Summary
Update Open traces action
web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx, web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx
The route now gates “Open traces” with INTAKE_ENABLED, uses getIntakeTracesRoute, and displays the ListTree icon. Tests configure the flag, register the intake-traces route, and verify navigation.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change to route the agent Open traces button to Intake traces.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nwalston/astd-402-agents-opening-traces-navigates-to-the-monitor-tab-instead

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 33336/42102 79.2% 64.1%
Integration Tests N/A N/A N/A

Match the AppBar Traces nav icon instead of Activity.

Signed-off-by: Nathan Walston <nwalston@nvidia.com>
@walston
walston enabled auto-merge August 14, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants