fix(studio): point agent Open traces button to Intake traces - #1292
Open
walston wants to merge 2 commits into
Open
fix(studio): point agent Open traces button to Intake traces#1292walston wants to merge 2 commits into
walston wants to merge 2 commits into
Conversation
The agent detail page Open traces button navigated to the Monitor tab and was gated behind MONITOR_ENABLED. Retarget it to the Intake traces route and gate on INTAKE_ENABLED so it renders and links to Traces. Fixes ASTD-402 Signed-off-by: Nathan Walston <nwalston@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesAgent intake traces navigation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
aray12
approved these changes
Aug 13, 2026
Match the AppBar Traces nav icon instead of Activity. Signed-off-by: Nathan Walston <nwalston@nvidia.com>
walston
enabled auto-merge
August 14, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Open traces" button on the agent detail page navigated to the Monitor tab (
/agents/monitor) and was gated behindMONITOR_ENABLED, so with Monitor disabled it was hidden entirely. It now navigates to the Intake Traces route (/intake/traces) and is gated behindINTAKE_ENABLED, so it renders and links to Traces as intended.Related Issue
ASTD-402: https://linear.app/nvidia/issue/ASTD-402
Changes
AgentDetailRoute/index.tsx: swapgetAgentMonitorRoute→getIntakeTracesRouteandMONITOR_ENABLED→INTAKE_ENABLEDfor the "Open traces" button, and use theListTreeicon to match the AppBar Traces nav item (wasActivity).AgentDetailRoute/index.test.tsx: stubVITE_FF_INTAKE_ENABLED, and add a test asserting the button navigates to the Intake traces route.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
pnpm --filter nemo-studio-ui exec vitest run src/routes/agents/AgentDetailRoute/index.test.tsx→ 4 passed (incl. new navigation guard).pnpm exec prettier --checkon changed files → clean.pnpm exec eslinton changed files → clean.pnpm --filter nemo-studio-ui run typecheck→ clean.uv run pre-commit run -anot run; change is web-only, and CI runs the full gate.Summary by CodeRabbit
New Features
Tests