Add missing soil moisture and temperature fields to default field metadata in FV3-JEDI#2180
Draft
tsga wants to merge 7 commits into
Draft
Add missing soil moisture and temperature fields to default field metadata in FV3-JEDI#2180tsga wants to merge 7 commits into
tsga wants to merge 7 commits into
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR currently updates the sorc/land-jediincr git submodule configuration (URL and branch). This does not match the PR title/description, which describe adding missing FV3-JEDI soil metadata fields for DA workflows.
Changes:
- Switches
sorc/land-jediincrsubmodule to a different GitHub repository and branch. - Adds inline “comments” on the
urlandbranchlines (which affects how Git parses the values).
Comment on lines
+46
to
+47
| url = https://github.com/tsga/land-apply_jedi_incr #https://github.com/NOAA-EMC/land-apply_jedi_incr.git | ||
| branch = soilinc #develop |
| path = sorc/land-jediincr | ||
| url = https://github.com/NOAA-EMC/land-apply_jedi_incr.git | ||
| branch = develop | ||
| url = https://github.com/tsga/land-apply_jedi_incr #https://github.com/NOAA-EMC/land-apply_jedi_incr.git |
Comment on lines
+46
to
+47
| url = https://github.com/tsga/land-apply_jedi_incr #https://github.com/NOAA-EMC/land-apply_jedi_incr.git | ||
| branch = soilinc #develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default metadata in FV3-JEDI doesn't include the soil layer variables such as soill1, soilt1... which are required for land/sfc soil moisture DA with observations from satellite products such as SMAP and near surface station temperature and humidity observations. This PR adds these variables.
Companion PRs
JCSDA/fv3-jedi#30
Issues
Automated CI tests to run in Global Workflow