Update the code to be compatible with pandas==3 #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlehoff
force-pushed
the
update_for_pandas3
branch
from
6e3907e to
9472cbf
Compare
Radonirinaunimi
approved these changes
Jan 27, 2026
Member
Author
|
Thanks @Radonirinaunimi I'll run the bot to update the target in case there are any fluctuations. |
Member
Yes! At some point, people didn't have pre-commit check the commondata implementation. One way to circumvent this is to also run pre-commit on the CI but that might too much. |
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue were the many
groupby, see the deprecation notice here: https://pandas.pydata.org/pandas-docs/version/2.3/reference/api/pandas.DataFrame.groupby.htmlthe rest were trivial. This should also work fine with pandas <3 and we'll see less deprecation warnings so win-win.
The many changes to the flters are due to pre-commit, that had never been ran? Or ran too long ago? The pandas change there is very minimal, just a few
to_numpy()that needed to be not read only.