Skip to content

fix(security): harden GUI preset and auth handling#13

Merged
Microck merged 1 commit into
mainfrom
fix/security-gui-hardening
Apr 12, 2026
Merged

fix(security): harden GUI preset and auth handling#13
Microck merged 1 commit into
mainfrom
fix/security-gui-hardening

Conversation

@Microck
Copy link
Copy Markdown
Owner

@Microck Microck commented Apr 12, 2026

What changed

  • redact sensitive preset fields from GET /api/presets
  • reject invalid GUI enrollment mode, channel, and negative durations before workflow execution
  • use a bounded HTTP client for device deletion
  • pass tailscale auth keys through a temp file instead of process argv

Why

  • the presets API was exposing Tailscale credentials to the browser
  • GUI input validation was too permissive
  • device deletion should not hang indefinitely
  • auth keys should not appear in process listings

Verification

  • go test ./...
  • go vet ./...

Redact sensitive preset fields from the GUI presets API and reject invalid enrollment mode, channel, and duration input before reaching the workflow layer.

Harden Tailscale operations by using a bounded HTTP client for device deletion and passing auth keys through a temporary file instead of process argv, with regression tests covering the API and transport behavior.
@Microck Microck merged commit bcd957d into main Apr 12, 2026
1 check passed
@Microck Microck deleted the fix/security-gui-hardening branch April 12, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant