[nightshift] API contract verification: security fix + validation + docs#6
Closed
nightshift-micr wants to merge 1 commit into
Closed
Conversation
Owner
|
Closing as superseded by #13. The security-sensitive parts from this PR are now merged into main, with focused tests covering preset redaction and GUI input validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by Nightshift v3 (GLM 5.1).
Task: API Contract Verification
Category: pr
Changes:
Critical Security Fix
/api/presetscredential leak: TheGET /api/presetsendpoint was serializing the fullmodel.Presetstruct to JSON, which includesauthKey,authKeyEnv,ephemeralAuthKey,ephemeralAuthKeyEnv,cleanup.apiKey, andcleanup.apiKeyEnv. These are sensitive Tailscale credentials that should never reach the browser. Introduced apresetSummarystruct that only exposes non-sensitive fields (id, description, tags, acceptRoutes, allowExitNodeSelection, approvedExitNodes).Bug Fixes
/api/presets: The endpoint accepted POST, PUT, DELETE etc. — now restricted to GET only./api/enroll: Themodeandchannelfields were blindly cast to enum types without checking they are valid values.daysandcustomDaysaccepted negative integers. All now validated.Documentation
state.Save,state.AppendAudit) and silent no-op behaviors (DeleteDevice,Uninstall).All existing tests pass. Build verified clean.
Merge if useful, close if not.