Skip to content

fix: Add 'nodeSelector' field for DTS deployment #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: Add 'nodeSelector' field for DTS deployment #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions manifests/state-doca-telemetry-service/0010-doca-telemetry-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ spec:
# Required by the sysfs collector only.
hostNetwork: true
serviceAccount: doca-telemetry-service
nodeSelector:
# We need to run it after DOCA driver is started to be able successfully restart driver by a container.
feature.node.kubernetes.io/pci-15b3.present: "true"
network.nvidia.com/operator.mofed.wait: "false"
Copy link
Collaborator

@adrianchiris adrianchiris Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment why this label is needed for posterity :) ?

Copy link
Collaborator Author

@e0ne e0ne Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment why this label is needed for posterity :) ?

is'n it enough to have it in a commit message only?

Copy link
Collaborator

@adrianchiris adrianchiris Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so we dont need to dig into commits about this.

Copy link
Collaborator Author

@e0ne e0ne Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

{{- if .NodeAffinity }}
affinity:
nodeAffinity:
Expand Down
Loading