fix: Add 'nodeSelector' field for DTS deployment #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0ne
force-pushed
the
dts-node-selector
branch
from
14fc417 to
687b0cf
Compare
e0ne
changed the title
Collaborator
Pull Request Test Coverage Report for Build 11719409002Details
💛 - Coveralls |
adrianchiris
previously approved these changes
Oct 29, 2024
| serviceAccount: doca-telemetry-service | ||
| nodeSelector: | ||
| feature.node.kubernetes.io/pci-15b3.present: "true" | ||
| network.nvidia.com/operator.mofed.wait: "false" |
Collaborator
There was a problem hiding this comment.
can you add a comment why this label is needed for posterity :) ?
Collaborator
Author
There was a problem hiding this comment.
can you add a comment why this label is needed for posterity :) ?
is'n it enough to have it in a commit message only?
Collaborator
There was a problem hiding this comment.
just so we dont need to dig into commits about this.
rollandf
reviewed
Oct 29, 2024
e0ne
added
the
on hold
Member
|
/retest-image_scan |
e0ne
removed
the
on hold
rollandf
previously approved these changes
Nov 7, 2024
We need to run it after DOCA driver is started to be able successfully restart driver by a container. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
force-pushed
the
dts-node-selector
branch
from
687b0cf to
1309fcd
Compare
rollandf
approved these changes
Nov 7, 2024
vasrem
approved these changes
Nov 11, 2024
ykulazhenkov
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to run it after DOCA driver is started to be able successfully restart driver by a container.