Add plugin mode argument to decide which folder to place the socket file #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuchenCN
changed the title
xuchenCN
changed the title
xuchenCN
force-pushed
the
xuchenCN-patch-1
branch
from
91e1cce to
608321d
Compare
almaslennikov
requested changes
Sep 29, 2025
Collaborator
almaslennikov
left a comment
almaslennikov
left a comment
There was a problem hiding this comment.
Hi @xuchenCN, thank you for the contribution!
I've left a few comments to the PR.
Please, make sure that all CI checks pass. For DCO check, you need to sign all the commits in the PR: https://github.com/Mellanox/k8s-rdma-shared-dev-plugin/pull/201/checks?check_run_id=49058953942
Author
|
@almaslennikov |
Collaborator
|
@xuchenCN build and test CI workflows are failing. Please make sure your changes work. |
xuchenCN
force-pushed
the
xuchenCN-patch-1
branch
from
39676d7 to
20f73be
Compare
Signed-off-by: xuchenCN <[email protected]>
xuchenCN
force-pushed
the
xuchenCN-patch-1
branch
from
20f73be to
82592dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #200