Skip to content

Commit 82592dd

Browse files
committed
add plugin mode
Signed-off-by: xuchenCN <[email protected]>
1 parent e389db4 commit 82592dd

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

cmd/k8s-rdma-shared-dp/main.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ func main() {
6868
useCdi := false
6969
flag.BoolVar(&useCdi, "use-cdi", false,
7070
"Use Container Device Interface to expose devices in containers")
71+
kubeletPluginMode := false
72+
flag.BoolVar(&kubeletPluginMode, "kubelet-plugin-mode", true,
73+
"Using Kubelet Plugin Registry Mode if true, else to using Deprecated Device Plugin Registry Path ")
7174
flag.Parse()
7275
if versionOpt {
7376
fmt.Printf("%s\n", printVersionString())
@@ -80,7 +83,7 @@ func main() {
8083

8184
log.Println("Starting K8s RDMA Shared Device Plugin version=", version)
8285

83-
rm := resources.NewResourceManager(configFilePath, useCdi)
86+
rm := resources.NewResourceManager(configFilePath, useCdi, kubeletPluginMode)
8487

8588
log.Println("resource manager reading configs")
8689
if err := rm.ReadConfig(); err != nil {

pkg/resources/resources_manager.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,18 +90,17 @@ type resourceManager struct {
9090
useCdi bool
9191
}
9292

93-
func NewResourceManager(configFile string, useCdi bool) types.ResourceManager {
94-
watcherMode := detectPluginWatchMode(activeSockDir)
95-
if watcherMode {
93+
func NewResourceManager(configFile string, useCdi, kubeletPluginMode bool) types.ResourceManager {
94+
if kubeletPluginMode {
9695
fmt.Println("Using Kubelet Plugin Registry Mode")
9796
} else {
98-
fmt.Println("Using Deprecated Devie Plugin Registry Path")
97+
fmt.Println("Using Deprecated Device Plugin Registry Path")
9998
}
10099
return &resourceManager{
101100
configFile: configFile,
102101
defaultResourcePrefix: rdmaHcaResourcePrefix,
103102
socketSuffix: socketSuffix,
104-
watchMode: watcherMode,
103+
watchMode: kubeletPluginMode,
105104
netlinkManager: &netlinkManager{},
106105
rds: NewRdmaDeviceSpec(requiredRdmaDevices),
107106
useCdi: useCdi,

pkg/resources/resources_manager_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ var _ = Describe("ResourcesManger", func() {
8080
activeSockDir = activeSockDirBackUP
8181
}()
8282

83-
obj := NewResourceManager(DefaultConfigFilePath, false)
83+
obj := NewResourceManager(DefaultConfigFilePath, false, true)
8484
rm := obj.(*resourceManager)
8585
Expect(rm.watchMode).To(Equal(true))
8686
})
@@ -92,7 +92,7 @@ var _ = Describe("ResourcesManger", func() {
9292
activeSockDir = activeSockDirBackUP
9393
}()
9494

95-
obj := NewResourceManager(DefaultConfigFilePath, false)
95+
obj := NewResourceManager(DefaultConfigFilePath, false, true)
9696
rm := obj.(*resourceManager)
9797
Expect(rm.watchMode).To(Equal(false))
9898
})

0 commit comments

Comments
 (0)