Demo Save-to-Drive: ON by default + discoverable for hackathon judges (deployed) - #279
Closed
Mawar2 wants to merge 4 commits into
Closed
Demo Save-to-Drive: ON by default + discoverable for hackathon judges (deployed)#279Mawar2 wants to merge 4 commits into
Mawar2 wants to merge 4 commits into
Conversation
…-to-Drive Demo-prep UI for the gate (per Malik): - Pad the aggregated gap-summary status bar above 'What Tomás produced' and add a prominent 'Open full editor mode' button (top + artifact row). - Remove the gold OpenFlags boxes and the per-section gap bars / Show-list / Next-gap controls from the gate — gap resolution now lives ONLY on the full editor (/editor); the gate stays a clean review surface (keeps the gap-warn textarea highlight + the summary). - Rename 'Submit to SAM.gov' -> 'Save to Google Drive' (done + submitted states). - Demo mode: a persisted toggle reveals a 'Save to Google Drive' action at the gate that saves the package from any state (SubmitDemo, demo=1), skipping the ready-to-submit gate; production submit is unchanged. Tests updated: TestWorkspaceGateAggregatesGaps (new gate layout + editor keeps gap controls), TestProposalFlowOverHTTP (renamed copy), +TestDemoSubmitFromGate.
…rive submit panel Per Malik: the 'Save to Google Drive' button no longer sits in the human-review action row. Demo mode now SWAPS the gate's Approve/Request-changes actions for a distinct submit panel (Demo mode · Save to Google Drive) that bypasses any open [GAP] markers — so a presenter blocked by gaps can still reach submit. The Demo mode toggle sits just above the actions (persistent, so it can be toggled off); when on it hides [data-demo-hide] (the review actions) and reveals [data-demo-only] (the submit panel).
…swaps actions↔submit panel
…Save-to-Drive together Hackathon judges self-testing the deployed app won't discover a hidden toggle, so default demo mode ON: the gate shows Approve/Request-changes AND a labeled 'Demo mode · Save to Google Drive' panel that bypasses open [GAP] markers. The toggle (now self-describing) persists an off state for a strict review walkthrough. Drops the action-swap; the panel is its own labeled block.
Owner
Author
|
Superseded by #280 — a clean re-land of the same net change (proposals_templates.go, demo-mode-ON-by-default) off current origin/main, avoiding the stacked-squash conflict this PR hit. Already live on Cloud Run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #276, deployed (rev 00018-j8l, image aaacec3).
.demo-submit{display:flex}overrode the[hidden]attribute.go test ./... green. Merged under deadline authorization.
🤖 Generated with Claude Code