Skip to content

[Fix] Fix download function #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-diedrich merged 4 commits into from
Jun 11, 2026
Merged

[Fix] Fix download function #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bf417f
[Fix] Fix downloads, accept missing files when removing
lucas-diedrich Jun 10, 2026
3d4fcb4
[Fix] Fix at second occurence
lucas-diedrich Jun 10, 2026
9ff9408
[Fix] Round points instead of flooring
lucas-diedrich Jun 10, 2026
e49f833
Merge pull request #66 from MannLabs/fix/coordinate-rounding
lucas-diedrich Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lmd/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _sanitize_file_name(file_name):
warning = f"File {download_to_path} already exists!"
if not overwrite:
print(warning)
Path(lock_path).unlink()
Path(lock_path).unlink(missing_ok=True)
return
else:
print(f"{warning} Overwriting...")
Expand All @@ -108,7 +108,7 @@ def _sanitize_file_name(file_name):
else:
download_to_path.with_name(output_file_name)

Path(lock_path).unlink()
Path(lock_path).unlink(missing_ok=True)


def _download_glyphs() -> Path:
Expand Down
8 changes: 4 additions & 4 deletions src/lmd/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,10 @@ def save(self, file_location: str, encoding: str = "utf-8"):

id = i + 1
x = ET.SubElement(root, f"X_CalibrationPoint_{id}")
x.text = f"{np.floor(point[0]).astype(int)}"
x.text = f"{int(round(point[0], 0))}"

y = ET.SubElement(root, f"Y_CalibrationPoint_{id}")
y.text = f"{np.floor(point[1]).astype(int)}"
y.text = f"{int(round(point[1], 0))}"

# write shape length
shape_count = ET.SubElement(root, "ShapeCount")
Expand Down Expand Up @@ -687,10 +687,10 @@ def to_xml(
for i, point in enumerate(transformed_points):
id = i + 1
x = ET.SubElement(shape, f"X_{id}")
x.text = f"{np.floor(point[0]).astype(int)}"
x.text = f"{int(round(point[0], 0))}"

y = ET.SubElement(shape, f"Y_{id}")
y.text = f"{np.floor(point[1]).astype(int)}"
y.text = f"{int(round(point[1], 0))}"

return shape

Expand Down
Loading