[Fix] Fix download function#67
Merged
Merged
Conversation
lucas-diedrich
force-pushed
the
fix/download
branch
from
30d952e to
3d4fcb4
Compare
mschwoer
approved these changes
Jun 11, 2026
[Fix] Round points instead of flooring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Manual fix, summary generated by Claude]
Problem
The download-dependent tests (test_glyphs, test_segmentation_loader) fail in CI with:
The traceback points at src/lmd/_utils.py:111, after the download has completed successfully (the progress bar reaches 100%).
Root cause
_download wraps the download in a with FileLock(lock_path): block, but then also calls Path(lock_path).unlink() manually to clean up the lock file. FileLock manages the lifecycle of its own .lock file, and with the filelock version resolved in CI the lock file is already gone once the context manager exits. The unguarded unlink() therefore raises FileNotFoundError.
Fix
Make the cleanup tolerant of an already-removed lock file, consistent with the early-return path