Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a mechanism to apply operator-provided MISP settings from a JSON file during container startup, enabling configuration beyond the existing env-var-driven and safe-default settings system.
Changes:
- Added
MISP_SETTINGS_FILEsupport and an optionalsettings.jsonbind mount to apply arbitrary MISP settings on boot. - Documented the new startup-settings workflow in the README and surfaced the new env var in
template.env. - Ignored
settings.jsonin git to avoid accidental commits.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
template.env |
Documents the new MISP_SETTINGS_FILE env var (commented). |
README.md |
Adds instructions and an example for providing startup settings via settings.json. |
docker-compose.yml |
Adds an optional settings.json volume mount and passes MISP_SETTINGS_FILE into misp-core. |
core/files/configure_misp.sh |
Implements applying settings from JSON via cake Admin setSetting at startup. |
.gitignore |
Adds settings.json to ignore list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for custom MISP settings at startup. Mounting a json file is way easier than putting a escaped json in the .env file