Allow setting MISP.curl_request_timeout via env var#404
Allow setting MISP.curl_request_timeout via env var#404firefart wants to merge 1 commit intoMISP:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for configuring MISP’s MISP.curl_request_timeout through a CURL_REQUEST_TIMEOUT environment variable in the Docker deployment.
Changes:
- Document
CURL_REQUEST_TIMEOUTintemplate.env. - Pass
CURL_REQUEST_TIMEOUTinto themisp-corecontainer viadocker-compose.yml. - Export a default
CURL_REQUEST_TIMEOUTvalue incore/files/entrypoint.shand wire it into MISP settings enforcement viacore/files/etc/misp-docker/optional.envars.json.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| template.env | Adds commented documentation for the new env var. |
| docker-compose.yml | Passes CURL_REQUEST_TIMEOUT into the misp-core service environment. |
| core/files/etc/misp-docker/optional.envars.json | Enforces MISP.curl_request_timeout from the env var. |
| core/files/entrypoint.sh | Exports CURL_REQUEST_TIMEOUT with a default value (300). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@UFOSmuggler we really need a better approach here :) (clarification: here = MISP settings via env var) |
|
@ostefano should I look into a mechanism to set arbitrary settings to address this in a more general way? |
|
Yup, at least for all the options ending up in MISP I believe we should have just one env variable, with all values encoded inside JSON encoded dictionary. Not a trivial change. |
This allows setting the
MISP.curl_request_timeoutsetting via theCURL_REQUEST_TIMEOUTenvironment variable