Skip to content

Allow setting MISP.curl_request_timeout via env var#404

Closed
firefart wants to merge 1 commit intoMISP:masterfrom
firefart:curl_timeout
Closed

Allow setting MISP.curl_request_timeout via env var#404
firefart wants to merge 1 commit intoMISP:masterfrom
firefart:curl_timeout

Conversation

@firefart
Copy link
Copy Markdown
Contributor

This allows setting the MISP.curl_request_timeout setting via the CURL_REQUEST_TIMEOUT environment variable

Copilot AI review requested due to automatic review settings March 31, 2026 12:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for configuring MISP’s MISP.curl_request_timeout through a CURL_REQUEST_TIMEOUT environment variable in the Docker deployment.

Changes:

  • Document CURL_REQUEST_TIMEOUT in template.env.
  • Pass CURL_REQUEST_TIMEOUT into the misp-core container via docker-compose.yml.
  • Export a default CURL_REQUEST_TIMEOUT value in core/files/entrypoint.sh and wire it into MISP settings enforcement via core/files/etc/misp-docker/optional.envars.json.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
template.env Adds commented documentation for the new env var.
docker-compose.yml Passes CURL_REQUEST_TIMEOUT into the misp-core service environment.
core/files/etc/misp-docker/optional.envars.json Enforces MISP.curl_request_timeout from the env var.
core/files/entrypoint.sh Exports CURL_REQUEST_TIMEOUT with a default value (300).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ostefano
Copy link
Copy Markdown
Collaborator

ostefano commented Mar 31, 2026

@UFOSmuggler we really need a better approach here :) (clarification: here = MISP settings via env var)

@firefart
Copy link
Copy Markdown
Contributor Author

@ostefano should I look into a mechanism to set arbitrary settings to address this in a more general way?

@ostefano
Copy link
Copy Markdown
Collaborator

Yup, at least for all the options ending up in MISP I believe we should have just one env variable, with all values encoded inside JSON encoded dictionary. Not a trivial change.

@firefart
Copy link
Copy Markdown
Contributor Author

@ostefano #405

@firefart firefart closed this Mar 31, 2026
@firefart firefart deleted the curl_timeout branch March 31, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants