Skip to content

feature/larpandora_v10_03_00#52

Merged
lgarren merged 5 commits into
LArSoft:developfrom
PandoraPFA:feature/larpandora_v10_03_00
Jun 12, 2026
Merged

feature/larpandora_v10_03_00#52
lgarren merged 5 commits into
LArSoft:developfrom
PandoraPFA:feature/larpandora_v10_03_00

Conversation

@AndyChappell

@AndyChappell AndyChappell commented May 29, 2026

Copy link
Copy Markdown
Contributor

This PR for larpandora v10_03_00 augments the MC truth information passed to pandora.

Please note, this PR depends upon larpandoracontent PR 95.

Please also note that this is a breaking change for MicroBooNE product ubreco, the PR to address the breaking change is here.

No product changes are expected.

@FNALbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @AndyChappell for develop.

It involves the following packages:

larpandora

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild

Copy link
Copy Markdown
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild

Copy link
Copy Markdown
Contributor

+code-checks

@lgarren lgarren moved this to Awaiting triage in LArSoft pull requests May 29, 2026
@knoepfel knoepfel moved this from Awaiting triage to Approval in progress in LArSoft pull requests Jun 1, 2026
@AndyChappell

Copy link
Copy Markdown
Contributor Author

Added reference to associated ubreco PR.

@lgarren

lgarren commented Jun 4, 2026

Copy link
Copy Markdown
Member

trigger build with pull requests #52, LArSoft/larpandoracontent#95, uboone/ubreco#41

@FNALbuild

Copy link
Copy Markdown
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larpandoracontent#95,uboone/ubreco#41

@FNALbuild

Copy link
Copy Markdown
Contributor

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

@lgarren

lgarren commented Jun 8, 2026

Copy link
Copy Markdown
Member

trigger build with pull requests #52, LArSoft/larpandoracontent#95, uboone/ubreco#41

@FNALbuild

Copy link
Copy Markdown
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larpandoracontent#95,uboone/ubreco#41

@FNALbuild

Copy link
Copy Markdown
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larpandoracontent#95,uboone/ubreco#41

@lgarren

lgarren commented Jun 10, 2026

Copy link
Copy Markdown
Member

trigger build with pull requests #52, LArSoft/larpandoracontent#95, uboone/ubreco#41

@FNALbuild

Copy link
Copy Markdown
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larpandoracontent#95,uboone/ubreco#41

@FNALbuild

Copy link
Copy Markdown
Contributor

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

@FNALbuild

Copy link
Copy Markdown
Contributor

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

@FNALbuild

Copy link
Copy Markdown
Contributor

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

@FNALbuild

Copy link
Copy Markdown
Contributor

-SBND tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/20889&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/30199&builds=

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

-SBND tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/20889&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/30199&builds=

@FNALbuild

Copy link
Copy Markdown
Contributor

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

@FNALbuild

Copy link
Copy Markdown
Contributor

1 similar comment
@FNALbuild

Copy link
Copy Markdown
Contributor

@lgarren

lgarren commented Jun 11, 2026

Copy link
Copy Markdown
Member

approve

@FNALbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren moved this from Approval in progress to Approved and pending inclusion in release in LArSoft pull requests Jun 11, 2026
@lgarren lgarren merged commit c322b4b into LArSoft:develop Jun 12, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Approved and pending inclusion in release to Merged into develop in LArSoft pull requests Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged into develop

Development

Successfully merging this pull request may close these issues.

5 participants