Skip to content

Conversation

@DennisTemoye
Copy link
Contributor

Description:
This PR adds unit tests for the UsersController in the User module. The tests cover various functionalities, including:

Profile Retrieval: Verifying the correct retrieval of the current user profile.
User Lookup: Testing user search by ID and email with proper handling of both successful and failed cases.
Password Change: Ensuring that the change password functionality is tested with valid inputs.
Lead Creation: Testing the creation of a temporary lead registration.
Account Deactivation and Reactivation: Ensuring proper handling of account deactivation and reactivation requests.
New User Registration: Verifying new user registration functionality, including error handling when a failure occurs.

Changes:
Created unit tests for the UsersController using Jest.
Mocked the UsersService methods to ensure isolated testing.
Implemented test cases for the following routes:
/myProfile
/findAll
/findOne/:id
/findByUsername
/changePassword
/createLead
/register
/newUserForm
/deactivateAccount
/requestReactivation

Testing:
All tests have passed successfully.
Mocked service methods to isolate the controller logic.

@willypelz
Copy link
Member

we have some conflicts with this PR. @DennisTemoye

"@nestjs/schematics": "^10.0.0",
"@nestjs/testing": "^11.0.15",


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DennisTemoye an extra space added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no new change in package.json; There is no need to push your local installation changes. (package-lock.json)

@willypelz
Copy link
Member

@DennisTemoye any update on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants