added unit test for the first part of the user module #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willypelz
requested changes
May 15, 2025
Contributor
Author
|
My apologies @willypelz, I've added them back |
willypelz
reviewed
May 21, 2025
src/users/users.controller.spec.ts
Outdated
|
|
||
| // We would need to actually inject the real service to test this | ||
| // const result = usersService.paraseEncryptedParams(encryptedParams); | ||
|
|
Member
There was a problem hiding this comment.
@oyedeletemitope why do we have alot of comment codes? can we remove them if not used.
Tonykaynoni
reviewed
May 22, 2025
Member
Tonykaynoni
left a comment
Tonykaynoni
left a comment
There was a problem hiding this comment.
What's the major difference between this test and the one here #44 🤷🏿♂️
Contributor
Author
I think Dennis decided to test all the endpoints in the user module. I only tested for the ones assigned to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the user Module for the following endpoints